Re: Changes for RTEMS on ARM (at91rm9200ek)

[Ralph Lange <Ralph.Lange@bessy.de>]

Thanks Eric,

using the bsdnet_config value for malloc() was obviously a stupid left-over.
I also removed the ifdef'd code (which was only left for comparison, 
anyway).

I committed this fix and added all changes except the osdNetIntf.c stuff 
to the CVS trunk.
(Waiting for Jeff to approve the changes in osdNetIntf.c)

Cheers,
Ralph


Eric Norum wrote:
> The code in rtems_init.c looks a little weird.  Space is allocated 
> based on the length of rtems_bsdnet_config.hostname, but then used 
> with the length of whatever gethostname() returns.
>
> I think that it would be better to:
>     {
>         char hostname[1024];
>         gethostname(hostname, 1023);
>         char *cp = mustMalloc(strlen(hostname)+3, "iocsh prompt");
>         sprintf(cp, "%s> ", hostname);
>         epicsEnvSet ("IOCSH_PS1", cp);
>         epicsEnvSet("IOC_NAME", hostname);
>     }
>
> And get rid of the ifdef'd out code, too....
>
> On Sep 19, 2006, at 11:26 AM, Ralph Lange wrote:
>
> > Hi Jeff, Eric,
> >
> > I have commited changes for our RTEMS on ARM board to the 3.14 branch 
> > of the CVS.
> > These include
> >
> >    * a new Makefile snippet in configure/os
> >    * the change in libCom/osi/os/default/osdNetIntf.c to align the
> >      ifreq buffer
> >    * a change in libCom/osi/os/RTEMS/osdVME.h
> >    * changes in src/RTEMS/base (rtems_init.c and rtems_config.c)
> >
> > Please have a look and tell me if these changes are acceptable.
> > I didn't commit the them to the CVS trunk yet - will do as soon as 
> > you approve.
> >
> > Thanks a lot!
> >
> > Ralph