Re: caPutLog support for gateway

[Ralph Lange <Ralph.Lange@gmx.de>]

On 26.03.2014 14:57, Konrad, Martin wrote:
> Hi Ben, Hi Andrew!
>
> I'd like to bring your attention to two patches John Priller has
> developed for caPutLog and cagateway:
>
> 1. This patch makes a few modifications to caPutLog to allow it to be
> used by non-IOC applications like cagateway. See attached patch or [1]
> for details.
>
> 2. This patch adds the option to use caPutLog with the gateway. See [2]
> for details.
>
> Note that patch 2 requires patch 1 to be merged.
>
> Best regards,
>
> Martin
>
> [1] https://stash.nscl.msu.edu/users/konrad/repos/caputlog/commits
> [2]
> https://code.launchpad.net/~info-martin-konrad/+junk/epics-gateway-putlog


Looking at the gateway patches, here's a few things that I would like 
you to cross-check:

gateResources.cc, line 126:
Failing to create the mutex is not handled. Maybe use 
epicsMutexMustCreate() in this place?

I am a bit hesitant regarding the introduction of a new implementation 
for a ring buffer, given that libCom already offers ring buffers.

gateway.cc, line 1347:
The logic seems wrong. Shouldn't it rather loop while one OR the other 
task is not done yet?

Is the log output compatible with the output of a regular IOC using 
caPutLog? (Important when feeding into Splunk or a similar engine.)

Thanks a lot,
~Ralph