Re: 3.13.6 daylight-savings follies

[Andrew Johnson <anj@aps.anl.gov>]

Laznovsky, Michael wrote:
> What about all the stuff in extensions/ (like camonitor), which link to tsSubr.c?  
> Won't they get the time wrong for a while even though they may be running on Solaris 
> machines with the correct idea of what time it is?

Most of those should be available built against R3.14, and if you 
haven't upgraded to those versions yet you may have some work to do... 
However if the R3.14 versions are still using the old tsSubr.c code by 
linking against the compatibility library in extensions/src/ts then 
you'll need to update that code with these definitions:

#define TS_DST_BEGIN (59+14)    /* second Sun in Mar (Mar 1 = 59) */
#define TS_DST_END -304         /* first Sun in Nov (Nov 1 = 304) */


> --------------------------------------------------------------------------------
> ./camonitor/camonitor.c
> --------------------------------------------------------------------------------
>    287:   (void)tsStampToText(&cdData->stamp, TS_TEXT_MMDDYY, timeText);

We ship a camonitor in R3.14 Base, although it probably has different 
arguments.  You'll probably need to fix and rebuild base for your 
version if it's using the code from libCom.

> --------------------------------------------------------------------------------
> ./dm2k/dm2k/dm2kCdev.h
> --------------------------------------------------------------------------------
>    153: char * dm2k_tsStampToText (cdev_TS_STAMP* ts, int type, char* buffer);
>    155: #define tsStampToText dm2k_tsStampToText
>
> --------------------------------------------------------------------------------
> ./medm/medm/medmCdev.cc
> --------------------------------------------------------------------------------
>   1156: medm_tsStampToText (cdev_TS_STAMP* ts, int type, char* buffer)
>   1254: 	      tsStampToText(&timeVal.stamp,TS_TEXT_MONDDYYYY,tsTxt));
>
> --------------------------------------------------------------------------------
> ./medm/medm/medmCdev.h
> --------------------------------------------------------------------------------
>    155: char * medm_tsStampToText (cdev_TS_STAMP* ts, int type, char* buffer);
>    157: #define tsStampToText medm_tsStampToText

If you look at those carefully the routines {dm2k,medm}_tsStampToText() 
are provided locally and written in terms of the OS localtime() routine, 
and are then #defined to be used wherever tsStampToText is called (which 
it doesn't seem to be anyway).  I'm going to assume that the dm2k code 
is the same as the medm code that I looked at.

> ..... and many more (ChannelWatcher, Ezca, osiTimeHelper.cpp, ar, ca, caTCL, cau, 
> syd/*)

You will need to check and probably rebuild them all if they're still 
building against R3.13.

Janet just checked our R3.14 extensions here, and we're only building ar 
and cau that need the ts library.  We'll be rebuilding both of them with 
a patched extensions libts.a file before next weekend.

- Andrew
--
The right to be heard does not automatically include
the right to be taken seriously. -- Hubert H. Humphrey