Re: A patch for medm

[Andrew Johnson <anj@aps.anl.gov>]

Kate Feng wrote:
> MEDM version 3.03 :
>
> When I defined only three states for a  mbbo record,
> the following warning message will pop up whenever  CA is
> connected.
>
> menuUpdateValueCb: Got state 3.
>  Only have strings for 3 states (starting at 0).
>  Kate:Mset_formatmode

Your record has three state strings for states #0, 1 and 2, but the VAL 
field is set to 3 which does not correspond to a valid state.  Either 
you need to define a fourth state string, or change the record so it is 
never set to the value 3.  This is not a bug in MEDM.

> A  minor patch  stops the warining message:
>
> diff -c -u medmMenu.c.orig medmMenu.c
>
> --- medmMenu.c.orig Tue Jun 10 12:13:27 2003
> +++ medmMenu.c Thu Nov 29 07:24:48 2007
> @@ -510,7 +510,7 @@
>         XmNnumChildren,&numChildren,
>         NULL);
>       i = (int) pr->value;
> -      if((i >=0) && (i < (int) numChildren)) {
> +      if((i >=0) && (i <= (int) numChildren)) {

This change would add an off-by-one bug to MEDM, which we will not do. 
As the warning message states, there are only three defined states for 
this record starting at state number 0.  With your fix in place, try 
putting the integer value 4 into that MBBO record and you'll get the 
same problem, showing that you haven't fixed what you think you have.

- Andrew
--
When a distinguished but elderly scientist states that something is
possible, he is almost certainly right.  When he states that something
is impossible, he is very probably wrong.  -- Arthur C. Clarke