Experimental Physics and Industrial Control System
On Thursday 03 September 2009 10:50:27 Eric Norum wrote:
> I've attached a patch file of changes to the SNC/SEQ subversion head.
> Most are to clean up warnings.
>
> 1) Converted all functions to ANSI-style argument lists. Fixed some
> call errors uncovered by this.
You missed converting a block of forward definitions towards the top of
phase2.c, they need an explicit (void) rather than just () which still looks
like K&R to the compiler.
> 2) Added prototypes.
> 3) Fixed some pointer/int warnings.
> 4) Converted format to 'EPICS standard' (no hard tabs)
>
> Comments, suggestions?
Could you regenerate the patch with a '-b' flag to diff, I can't review the
other changes because they're hidden by all the tab=>space fixes (I've been
asking people to send patches to core-talk so they can be reviewed, but white
space changes don't really need reviewing).
Thanks,
- Andrew
--
The best FOSS code is written to be read by other humans -- Harold Welte
- Replies:
- Re: SNC/SEQ changes Eric Norum
- References:
- SNC/SEQ changes Eric Norum
- Navigate by Date:
- Prev:
SNC/SEQ changes Eric Norum
- Next:
Re: SNC/SEQ changes Eric Norum
- Index:
2002
2003
2004
2005
2006
2007
2008
<2009>
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
- Navigate by Thread:
- Prev:
SNC/SEQ changes Eric Norum
- Next:
Re: SNC/SEQ changes Eric Norum
- Index:
2002
2003
2004
2005
2006
2007
2008
<2009>
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024