Experimental Physics and
Industrial Control System

Eric Norum <[email protected]> · Thu, 3 Sep 2009 11:44:03 -0500

On Sep 3, 2009, at 11:28 AM, Andrew Johnson wrote:

On Thursday 03 September 2009 10:50:27 Eric Norum wrote:

I've attached a patch file of changes to the SNC/SEQ subversion head.
Most are to clean up warnings.

1) Converted all functions to ANSI-style argument lists.  Fixed some
call errors uncovered by this.

You missed converting a block of forward definitions towards the top

of

phase2.c, they need an explicit (void) rather than just () which

still looks

like K&R to the compiler.

Thanks.
Done.

The only one left now is read(). Is there an EPICS header that gets

us the raw system call prototypes in an OS-independent fashion?

2) Added prototypes.
3) Fixed some pointer/int warnings.
4) Converted format to 'EPICS standard' (no hard tabs)

Comments, suggestions?

Could you regenerate the patch with a '-b' flag to diff, I can't

review the

other changes because they're hidden by all the tab=>space fixes

(I've been

asking people to send patches to core-talk so they can be reviewed,

but white

space changes don't really need reviewing).

Oops.
Forgot about the -b flag last time.

sncseq.patch.bz2

--
Eric Norum <[email protected]>
Advanced Photon Source
Argonne National Laboratory
(630) 252-4793

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System