Experimental Physics and
Industrial Control System

Andrew Johnson <[email protected]> · Thu, 3 Sep 2009 11:28:50 -0500

On Thursday 03 September 2009 10:50:27 Eric Norum wrote:
> I've attached a patch file of changes to the SNC/SEQ subversion head.
> Most are to clean up warnings.
>
> 1) Converted all functions to ANSI-style argument lists.  Fixed some
> call errors uncovered by this.

You missed converting a block of forward definitions towards the top of 
phase2.c, they need an explicit (void) rather than just () which still looks 
like K&R to the compiler.

> 2) Added prototypes.
> 3) Fixed some pointer/int warnings.
> 4) Converted format to 'EPICS standard' (no hard tabs)
>
> Comments, suggestions?

Could you regenerate the patch with a '-b' flag to diff, I can't review the 
other changes because they're hidden by all the tab=>space fixes (I've been 
asking people to send patches to core-talk so they can be reviewed, but white 
space changes don't really need reviewing).

Thanks,

- Andrew
-- 
The best FOSS code is written to be read by other humans -- Harold Welte

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System