EPICS Home

Experimental Physics and Industrial Control System


 
2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  <20192020  2021  2022  2023  2024  2025  Index 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  <20192020  2021  2022  2023  2024  2025 
<== Date ==> <== Thread ==>

Subject: Re: [Merge] ~epics-core/epics-base/+git/Com:iocsherr into epics-base:7.0
From: mdavidsaver via Core-talk <[email protected]>
To: mdavidsaver <[email protected]>
Date: Tue, 04 Jun 2019 08:18:44 -0000
> Why?

I'm regretting the exposure of iocshCmdDef::func and allowing outside code to directly call iocsh functions.  In retrospect, we should have insisted on having a wrapper function such as is being discussed now.

> handle "on" being called without the ioc shell being started, but you don't actually have to handle any of that

True, this is either "defensive programming", or laziness.  Easier to test for NULL than decide if it is impossible.  This is in part to ensure that external code (yours being the only I know of) won't be broken.

Maybe the question is whether you are motivated to work on this yourself?

And I suppose we are all dancing around the question of if/when to rewrite iocsh.cpp (as actual c++), or replace it with (something like) a lua interpreter shell.
-- 
https://code.launchpad.net/~epics-core/epics-base/+git/Com/+merge/366876
Your team EPICS Core Developers is subscribed to branch epics-base:7.0.

References:
[Merge] ~epics-core/epics-base/+git/Com:iocsherr into epics-base:7.0 mdavidsaver via Core-talk

Navigate by Date:
Prev: RE: C++ string question Mark Rivers via Core-talk
Next: Re: [Merge] ~epics-core/epics-base/+git/Com:make-simple into epics-base:7.0 mdavidsaver via Core-talk
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  <20192020  2021  2022  2023  2024  2025 
Navigate by Thread:
Prev: Re: [Merge] ~epics-core/epics-base/+git/Com:iocsherr into epics-base:7.0 Keenan Lang via Core-talk
Next: Re: [Merge] ~epics-core/epics-base/+git/Com:iocsherr into epics-base:7.0 Keenan Lang via Core-talk
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  <20192020  2021  2022  2023  2024  2025