Experimental Physics and
Industrial Control System

Keenan Lang via Core-talk <[email protected]> · Wed, 29 May 2019 15:54:43 -0000

>Not this much?

I don't particularly think it should really have any particular sway over base either, but Andrew asked about these changes, so I was questioning how far exactly he was thinking that parallel development should go.

>This evening I find myself regretting the addition of iocshFindCommand()

Why? I mean, I see you wrote in code to handle "on" being called without the ioc shell being started, but you don't actually have to handle any of that. ... Well, you should be handling the potential for null values in code that's reliant on entirely separate code to create such variables, but that's just good practices, not really iocshFindCommand's issue. "on error" doesn't need to do anything special in regards to outside code, it is the ioc shell's error handling, not any other shell's.

Outside shells are going to have their own error handling, all they need to know is that an error has occurred. And all that is needed for that to be communicated is a single function that takes in the iocshCmdDef and the iocshArgBuf and returns an error code.
-- 
https://code.launchpad.net/~epics-core/epics-base/+git/Com/+merge/366876
Your team EPICS Core Developers is subscribed to branch epics-base:7.0.

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System