Subject: |
Re: [Merge] ~epics-core/epics-base/+git/Com:iocsherr into epics-base:7.0 |
From: |
mdavidsaver via Core-talk <[email protected]> |
To: |
mdavidsaver <[email protected]> |
Date: |
Tue, 28 May 2019 04:39:11 -0000 |
Review: Needs Fixing
I've addressed some of the comments. The 'Scope' structure has been split in two pieces. The pre-thread pieces in iocshContext and the per-call in iocshScope.
Still need to trap arg parsing errors (cf. cvtArg() ).
> But all this ends up getting into a more overarching software design issue. How integrated should the lua shell be in the interior workings of the ioc shell?
Not this much? This evening I find myself regretting the addition of iocshFindCommand().
--
https://code.launchpad.net/~epics-core/epics-base/+git/Com/+merge/366876
Your team EPICS Core Developers is subscribed to branch epics-base:7.0.
- References:
- [Merge] ~epics-core/epics-base/+git/Com:iocsherr into epics-base:7.0 mdavidsaver via Core-talk
- Navigate by Date:
- Prev:
Re: [Merge] ~epics-core/epics-base/+git/Com:iocsherr into epics-base:7.0 Bruce Hill via Core-talk
- Next:
heard about the github sponsors? Jeong Han Lee via Core-talk
- Index:
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
<2019>
2020
2021
2022
2023
2024
- Navigate by Thread:
- Prev:
Re: [Merge] ~epics-core/epics-base/+git/Com:iocsherr into epics-base:7.0 Bruce Hill via Core-talk
- Next:
Re: [Merge] ~epics-core/epics-base/+git/Com:iocsherr into epics-base:7.0 Keenan Lang via Core-talk
- Index:
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
<2019>
2020
2021
2022
2023
2024
|