2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 <2020> 2021 2022 2023 2024 | Index | 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 <2020> 2021 2022 2023 2024 |
<== Date ==> | <== Thread ==> |
---|
Subject: | Re: make runtests fails with "touch: missing file operand" |
From: | "Johnson, Andrew N. via Core-talk" <core-talk at aps.anl.gov> |
To: | Dirk Zimoch <dirk.zimoch at psi.ch> |
Cc: | EPICS core-talk <core-talk at aps.anl.gov> |
Date: | Wed, 3 Jun 2020 17:59:56 +0000 |
Hi Dirk,
On Jun 3, 2020, at 3:06 AM, Zimoch Dirk (PSI) via Core-talk <core-talk at aps.anl.gov> wrote:
Looking at configure/RULES_MODULES I can see that this can happen if you have none of the submodules checked out. That is a legitimate configuration for Base which I know you use but I didn’t test, so my mistake, sorry!
Ralph – it wasn’t so much that there was a space in a variable, but that the rule wasn’t expecting the list of submodules to be empty.
Here’s a patch that should fix the problem, please let me know if it does so I can commit it (careful with wrapping, there are some long lines in it).
diff --git a/configure/RULES_MODULES b/configure/RULES_MODULES
index a163ce18d..57a459173 100644
--- a/configure/RULES_MODULES
+++ b/configure/RULES_MODULES
@@ -50,9 +50,11 @@ realclean:
# Append all our live submodule failure files
FAILURE_FILES = $(addsuffix /$(TEST_FAILURE_FILENAME), $(LIVE_SUBMODULES))
-runtests: | $(addsuffix $(DIVIDER)runtests, $(LIVE_SUBMODULES))
+define combine_failure_files
@$(TOUCH) $(FAILURE_FILES)
@$(CAT) $(FAILURE_FILES) >> $(TEST_FAILURE_FILE)
+endef
+runtests: | $(addsuffix $(DIVIDER)runtests, $(LIVE_SUBMODULES))
+
$(if $(FAILURE_FILES), $(combine_failure_files))
test-results: | $(addsuffix $(DIVIDER)test-results, $(LIVE_SUBMODULES))
- @$(TOUCH) $(FAILURE_FILES)
- @$(CAT) $(FAILURE_FILES) >> $(TEST_FAILURE_FILE)
+
$(if $(FAILURE_FILES), $(combine_failure_files))
- Andrew
--
Complexity comes for free, simplicity you have to work for.
|