Re: moving initHooks into libCom

[Andrew Johnson <anj@aps.anl.gov>]

On 12/08/2017 02:48 PM, Mark Rivers wrote:
> 
> I have tested that fix on VS2015 and VS2017.  It fixes the problem. 
> I am now building all of R7.0.1-rc1 with that patch on 2010, 2015,
> and 2017.

Great!

Michael, please push that commit to the master branch on github.

- Andrew


>> -----Original Message-----
>> From: core-talk-bounces@aps.anl.gov [mailto:core-talk-bounces@aps.anl.gov] On Behalf
>> Of Michael Davidsaver
>> Sent: Friday, December 08, 2017 2:32 PM
>> To: Andrew Johnson; core-talk@aps.anl.gov
>> Subject: Re: moving initHooks into libCom
>>
>> On 12/08/2017 03:29 PM, Andrew Johnson wrote:
>>> Michael,
>>>
>>> In case your Inbox filters out Jenkins emails the epics-master-windows
>>> APS job is now demonstrating the pva2pva build failure.
>>
>> I noticed.  If this is the only failure, then I might have it sorted out quickly.
>>
>> https://github.com/mdavidsaver/pva2pva/commit/049ed8cead5e59dea7f6631698c45ea63db
>> 78d66
>>
>>
>>> Thanks,
>>>
>>> - Andrew
>>>
>>> On 12/08/2017 02:09 PM, Andrew Johnson wrote:
>>>> On 12/08/2017 01:57 PM, Mark Rivers wrote:
>>>>> I forget exactly what CALL does, but I don't think it's necessary.  It's
>>>>> worth trying I guess.
>>>>
>>>> Yes, that fixed it. Jenkins runs build commands inside its own .BAT
>>>> file, and apparently executing one .BAT file inside another stops the
>>>> parent script. It's currently compiling using
>>>>
>>>>> Microsoft (R) C/C++ Optimizing Compiler Version 19.00.24215.1 for x64
>>>>
>>>> as against
>>>>
>>>>> Microsoft (R) C/C++ Optimizing Compiler Version 16.00.40219.01 for x64
>>>>
>>>>> Can you try the command interactively on that machine?
>>>>
>>>> I can't open a command window with the Jenkins build environment, the
>>>> Jenkins agent sets up the shell environment by itself, and it's
>>>> complicated by the fact that it's all running inside a JVM too.
>>>>
>>>> - Andrew
>>>>
>>>
> 

-- 
Arguing for surveillance because you have nothing to hide is no
different than making the claim, "I don't care about freedom of
speech because I have nothing to say." -- Edward Snowdon