Re: Is there a maximum threshold plugin for areaDetector?

["Marco A. Barra Montevechi Filho via Tech-talk" <tech-talk at aps.anl.gov>]

Agreed

Many thanks from Sirius too 🙂

---

From: Wang Xiaoqiang <xiaoqiang.wang at psi.ch>
Sent: 16 August 2023 03:17
To: Mark Rivers <rivers at cars.uchicago.edu>; Marco A. Barra Montevechi Filho <marco.filho at lnls.br>; tech-talk at aps.anl.gov <tech-talk at aps.anl.gov>
Subject: Re: Is there a maximum threshold plugin for areaDetector?

 

[You don't often get email from xiaoqiang.wang at psi.ch. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

That is exactly what the user requested. Thanks Mark!

On 8/15/23 21:29, Mark Rivers wrote:
> Folks,
>
> I have made the following changes to NDPluginProcess.  Note that these break backwards compatibility, because I think it would otherwise add confusion and complexity.
>
>   * Renamed LowClip to LowClipThresh and HighClip to HighClipThresh.
>   * Added LowClipValue and HighClipValue.
>   * Pixels whose values are greater than HighClipThresh are replaced with HighClipValue.
>   * Pixels whose values are less than LowClipThresh are replaced with LowClipValue
>
> I have attached these screenshots:
>
>   * NDProcess.png                 The medm screen with the new and modified widgets.  The LowClipThresh=300, LowClipValue=0, HighClipThresh=1000, HighClipValue=0.
>   * WithoutClipping.png       SimDetector image with low and high clipping disabled.
>   * WithClipping.png             SimDetector imaging with low and high clipping enabled.
>
> The new version is in the enhance_clip branch of ADCore on Github.
>
> https://github.com/areaDetector/ADCore/tree/enhance_clip <https://github.com/areaDetector/ADCore/tree/enhance_clip>
>
> Please let me know if this seems OK.
>
> Mark
>
> *From:* Marco A. Barra Montevechi Filho <marco.filho at lnls.br <mailto:marco.filho at lnls.br>>
> *Sent:* Tuesday, August 15, 2023 11:37 AM
> *To:* Mark Rivers <rivers at cars.uchicago.edu <mailto:rivers at cars.uchicago.edu>>; Wang Xiaoqiang <xiaoqiang.wang at psi.ch <mailto:xiaoqiang.wang at psi.ch>>; tech-talk at aps.anl.gov <mailto:tech-talk at aps.anl.gov>
> *Subject:* Re: Is there a maximum threshold plugin for areaDetector?
>
> Specifically for Sirius applications, it would be useful to set all values above upper threshold to zero. If i understand the current plugin, it only replaces the values above upper threshold with the upper threshold value itself, right?
>
> Im thinking about a threshold that determine which plugins will be replaced and the actual replacement value
>
> Thanks for your time,
>
> Marco
>
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> *From:*Mark Rivers <rivers at cars.uchicago.edu <mailto:rivers at cars.uchicago.edu>>
> *Sent:* 15 August 2023 12:40
> *To:* Wang Xiaoqiang <xiaoqiang.wang at psi.ch <mailto:xiaoqiang.wang at psi.ch>>; Marco A. Barra Montevechi Filho <marco.filho at lnls.br <mailto:marco.filho at lnls.br>>; tech-talk at aps.anl.gov <mailto:tech-talk at aps.anl.gov> <tech-talk at aps.anl.gov <mailto:tech-talk at aps.anl.gov>>
> *Subject:* RE: Is there a maximum threshold plugin for areaDetector?
>
> I agree that the clipping should be made more flexible.  I think it would be good to make this more general that replacing with 0 or the clip value.  Users might want to replace the clip values with non-zero user-specified values, for example -1, -2, etc.
>
> I will work on this soon.
>
> Mark
>
>
> -----Original Message-----
> From: Tech-talk <tech-talk-bounces at aps.anl.gov <mailto:tech-talk-bounces at aps.anl.gov>> On Behalf Of Wang Xiaoqiang via Tech-talk
> Sent: Tuesday, August 15, 2023 1:18 AM
> To: Marco A. Barra Montevechi Filho <marco.filho at lnls.br <mailto:marco.filho at lnls.br>>; tech-talk at aps.anl.gov <mailto:tech-talk at aps.anl.gov>
> Subject: Re: Is there a maximum threshold plugin for areaDetector?
>
>
> Hi Marco,
>
> In the NDPluginProcess, there is a clipping option. It clamps the pixel values within a given range.
>
> If by masking you mean zero the pixel value, there is no plugins I know of. I had such a need and wrote a request here,
> https://github.com/areaDetector/ADCore/issues/492 <https://github.com/areaDetector/ADCore/issues/492>
>
> Best
> Xiaoqiang
>
> On 8/14/23 21:11, Marco A. Barra Montevechi Filho via Tech-talk wrote:
>  > Hi all!
>  >
>  > Im using BadPixel plugin to mask some bad pixels in our detectors. The thing is some pixels only show broken values from time to time...
>  >
>  > Is there any plugin that would mask any pixel with a value above a certain configurable threshold value?
>  >
>  > In a similar line of thought, I noticed the statistics plugin allows the user to configure a minimal value (centroidThreshold) below which the pixel value is not going to be considered. Is there something similar for a *maximum* value?
>  >
>  > Thanks for any hints,
>  >
>  > Marco
>  >
>  > Aviso Legal: Esta mensagem e seus anexos podem conter informações confidenciais e/ou de uso restrito. Observe atentamente seu conteúdo e considere eventual consulta ao remetente antes de copiá-la, divulgá-la ou distribuí-la. Se você recebeu esta mensagem por engano, por favor avise o remetente e apague-a imediatamente.
>  >
>  > Disclaimer: This email and its attachments may contain confidential and/or privileged information. Observe its content carefully and consider possible querying to the sender before copying, disclosing or distributing it. If you have received this email by mistake, please notify the sender and delete it immediately.
>  >
>