> -----Original Message-----
> From: [email protected] [mailto:core-talk-
> [email protected]] On Behalf Of Andrew Johnson
> Sent: Friday, June 12, 2009 6:52 PM
> To: Core-Talk
> Subject: Patch: Move alarm.h and rename alarmString.h
>
> Michael Davidsaver suggests we make the changes in the attached patch,
> which moves alarm.h from src/dbStatic to src/ca and puts the static
> alarm strings into libca.
>
> We've never really got the alarm enums right; there are equivalent
> definitions in src/db/menuAlarmStat.dbd which must match alarm.h, and
> we currently have the header alarmString.h which currently instantiates
> a global alarm string array into whatever file it's included by. This
> is used both internally (by catools and cap5) and externally (by MEDM,
> ALH, etc).
>
> Unfortunately there are more alarm status string values than can be
> transported by CA as a DBF_ENUM, and even if they could be this
> wouldn't help very much given that the extended dbr_ types include a
> stat field anyway.
>
> I have made some (not terribly satisfactory) changes in this area since
> R3.14.10 but Michael's idea of putting the strings into libca seems
> interesting.
>
> Please discuss...
>
> - Andrew
> --
> The best FOSS code is written to be read by other humans -- Harold
> Welte
A slight change w/ respect to the previous patch. To prevent compilation problem with external tools an empty 'alarmString.h' is created in src/ca/, and defining epicsAlarmGLOBAL is not an error. Both ALH (1.2.23) and MEDM (3.1.4) compile and run without modification.
Michael
Attachment:
0001-move-alarm.h-and-rename-alarmString.h.patch
Description: 0001-move-alarm.h-and-rename-alarmString.h.patch
- Replies:
- RE: Patch: Move alarm.h and rename alarmString.h Jeff Hill
- References:
- Patch: Move alarm.h and rename alarmString.h Andrew Johnson
- Navigate by Date:
- Prev:
Patch: Move alarm.h and rename alarmString.h Andrew Johnson
- Next:
RE: Patch: Move alarm.h and rename alarmString.h Jeff Hill
- Index:
2002
2003
2004
2005
2006
2007
2008
<2009>
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
- Navigate by Thread:
- Prev:
Patch: Move alarm.h and rename alarmString.h Andrew Johnson
- Next:
RE: Patch: Move alarm.h and rename alarmString.h Jeff Hill
- Index:
2002
2003
2004
2005
2006
2007
2008
<2009>
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
|