Argonne National Laboratory

Experimental Physics and
Industrial Control System

2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  <20122013  2014  2015  2016  2017  2018  2019  Index 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  <20122013  2014  2015  2016  2017  2018  2019 
<== Date ==> <== Thread ==>

Subject: Re: [Merge] lp:~ralph-lange/epics-base/thread-hooks into lp:epics-base
From: Andrew Johnson <anj@aps.anl.gov>
To: Ralph Lange <Ralph.Lange@gmx.de>
Date: Fri, 29 Jun 2012 19:20:23 -0000
Should the AtThreadExits run before the ExitHooks?  You have this in several places:
  + epicsThreadRunExitHooks(pthreadInfo);
    epicsExitCallAtThreadExits ();
My feeling is that task-specific clean-up should happen before the generic task clean-up, so things nest nicely.

I think the Win32 calls to the epicsThreadRun*Hooks() routines belong in the epicsWin32ThreadEntry() routine, and epicsThreadHooksInit() should be called towards the bottom of fetchWin32ThreadGlobal() after the atexit() call but before initCompleted gets set (there doesn't look to be anything in the mutex creation code that would cause problems there).

Then with some tests in libCom/test/epicsThreadTest.cpp and comments in the Release Notes I think this should be good to go.  Eventually I'll want the API documenting in the AppDevGuide too, but not for this release.

Thanks,

- Andrew
-- 
https://code.launchpad.net/~ralph-lange/epics-base/thread-hooks/+merge/112806
Your team EPICS Core Developers is requested to review the proposed merge of lp:~ralph-lange/epics-base/thread-hooks into lp:epics-base.


References:
[Merge] lp:~ralph-lange/epics-base/thread-hooks into lp:epics-base Ralph Lange

Navigate by Date:
Prev: Re: [Merge] lp:~ralph-lange/epics-base/thread-hooks into lp:epics-base mdavidsaver
Next: Re: [Merge] lp:~ralph-lange/epics-base/thread-hooks into lp:epics-base Ralph Lange
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  <20122013  2014  2015  2016  2017  2018  2019 
Navigate by Thread:
Prev: Re: [Merge] lp:~ralph-lange/epics-base/thread-hooks into lp:epics-base Ralph Lange
Next: Re: [Merge] lp:~ralph-lange/epics-base/thread-hooks into lp:epics-base Ralph Lange
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  <20122013  2014  2015  2016  2017  2018  2019 
ANJ, 26 Nov 2012 Valid HTML 4.01! · Home · News · About · Base · Modules · Extensions · Distributions · Download ·
· Search · EPICS V4 · IRMIS · Talk · Bugs · Documents · Links · Licensing ·