EPICS Controls Argonne National Laboratory

Experimental Physics and
Industrial Control System

2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  <20142015  2016  2017  2018  2019  2020  2021  2022  2023  2024  Index 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  <20142015  2016  2017  2018  2019  2020  2021  2022  2023  2024 
<== Date ==> <== Thread ==>

Subject: Re: caPutLog support for gateway
From: Ralph Lange <[email protected]>
To: EPICS Core-Talk <[email protected]>
Cc: "Priller, John" <[email protected]>
Date: Thu, 27 Mar 2014 13:16:37 +0100
On 26.03.2014 14:57, Konrad, Martin wrote:
Hi Ben, Hi Andrew!

I'd like to bring your attention to two patches John Priller has
developed for caPutLog and cagateway:

1. This patch makes a few modifications to caPutLog to allow it to be
used by non-IOC applications like cagateway. See attached patch or [1]
for details.

2. This patch adds the option to use caPutLog with the gateway. See [2]
for details.

Note that patch 2 requires patch 1 to be merged.

Best regards,

Martin

[1] https://stash.nscl.msu.edu/users/konrad/repos/caputlog/commits
[2]
https://code.launchpad.net/~info-martin-konrad/+junk/epics-gateway-putlog


Looking at the gateway patches, here's a few things that I would like you to cross-check:

gateResources.cc, line 126:
Failing to create the mutex is not handled. Maybe use epicsMutexMustCreate() in this place?

I am a bit hesitant regarding the introduction of a new implementation for a ring buffer, given that libCom already offers ring buffers.

gateway.cc, line 1347:
The logic seems wrong. Shouldn't it rather loop while one OR the other task is not done yet?

Is the log output compatible with the output of a regular IOC using caPutLog? (Important when feeding into Splunk or a similar engine.)

Thanks a lot,
~Ralph


References:
caPutLog support for gateway Konrad, Martin

Navigate by Date:
Prev: caPutLog support for gateway Konrad, Martin
Next: Re: caPutLog support for gateway Benjamin Franksen
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  <20142015  2016  2017  2018  2019  2020  2021  2022  2023  2024 
Navigate by Thread:
Prev: caPutLog support for gateway Konrad, Martin
Next: Re: caPutLog support for gateway Benjamin Franksen
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  <20142015  2016  2017  2018  2019  2020  2021  2022  2023  2024 
ANJ, 16 May 2014 Valid HTML 4.01! · Home · News · About · Base · Modules · Extensions · Distributions · Download ·
· Search · EPICS V4 · IRMIS · Talk · Bugs · Documents · Links · Licensing ·