EPICS Controls Argonne National Laboratory

Experimental Physics and
Industrial Control System

2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  <20142015  2016  2017  2018  2019  2020  2021  2022  Index 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  <20142015  2016  2017  2018  2019  2020  2021  2022 
<== Date ==> <== Thread ==>

Subject: Re: [Merge] lp:~info-martin-konrad/epics-gateway/putlog into lp:epics-gateway
From: Benjamin Franksen <[email protected]>
To: <[email protected]>, <[email protected]>
Date: Mon, 19 May 2014 21:51:28 +0200
Am Montag, 19. Mai 2014, 19:21:21 schrieb Martin Konrad:
> > Looking at
> > https://code.launchpad.net/~info-martin-konrad/epics-gateway/putlog/+merge
> > /213921>
> >I have the feeling what the page shows me is not the whole change.
> >
> > For instance, I am not seeing any caPutLog includes being added.
>
> Have a look at gateResources.cc lines 36 to 39.

Oops. Like I said, just stupidity on my side...

> > Or maybe I see only the latest change on the branch and not the whole
> > diff? How can I see that?
>
> Nope, there are 3 commits on this branch. One adds the new code and two
> fix minor issues (I pushed them an hour ago). The merge view shows the
> changes introduced by all three commits.

Thanks, I hoped that was the case.

So. I've taken a close look and it all looks pretty neat and tidy to me and
gets my full approval, as far as I am able to judge (disclaimer: I am not
deeply familiar with the gateway code).

Cheers
Ben
--
Perl: There Is More Than One Way To Do It
Python: There Is One Way To Do It
Haskell: There Is One Way To Do It, Up To Isomorphisµ


________________________________

Helmholtz-Zentrum Berlin für Materialien und Energie GmbH

Mitglied der Hermann von Helmholtz-Gemeinschaft Deutscher Forschungszentren e.V.

Aufsichtsrat: Vorsitzender Prof. Dr. Dr. h.c. mult. Joachim Treusch, stv. Vorsitzende Dr. Beatrix Vierkorn-Rudolph
Geschäftsführung: Prof. Dr. Anke Rita Kaysser-Pyzalla, Thomas Frederking

Sitz Berlin, AG Charlottenburg, 89 HRB 5583

Postadresse:
Hahn-Meitner-Platz 1
D-14109 Berlin

http://www.helmholtz-berlin.de


References:
Re: [Merge] lp:~info-martin-konrad/epics-gateway/putlog into lp:epics-gateway Martin Konrad

Navigate by Date:
Prev: Re: [Merge] lp:~info-martin-konrad/epics-gateway/putlog into lp:epics-gateway Martin Konrad
Next: Re: [Merge] lp:~epics-core/epics-base/devlib2mmio into lp:epics-base Andrew Johnson
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  <20142015  2016  2017  2018  2019  2020  2021  2022 
Navigate by Thread:
Prev: Re: [Merge] lp:~info-martin-konrad/epics-gateway/putlog into lp:epics-gateway Martin Konrad
Next: Build failed in Jenkins: epics-base-3.14-rtems #10 APS Jenkins
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  <20142015  2016  2017  2018  2019  2020  2021  2022 
ANJ, 20 May 2014 Valid HTML 4.01! · Home · News · About · Base · Modules · Extensions · Distributions · Download ·
· Search · EPICS V4 · IRMIS · Talk · Bugs · Documents · Links · Licensing ·