Subject: |
Re: Problem with INSTALL_LOCATION and "make uninstall" in 7.0.1 |
From: |
Andrew Johnson <[email protected]> |
To: |
<[email protected]> |
Date: |
Fri, 15 Jun 2018 16:50:04 -0500 |
On 06/15/2018 04:40 PM, Mark Rivers wrote:
> One of the areaDetector optional plugins is in
> areaDetector/ADPluginEdge. Its CONFIG_SITE contains this line:
>
> INSTALL_LOCATION=$(AREA_DETECTOR)/ADCore
>
> It thus installs its library, dbd, and .template file into ADCore.
>
> Much to my surprise running “make uninstall” on EPICS 7 at the top level
> of ADPluginEdge deletes the ADCore/configure directory! Needed to run
> “git checkout master .” to recover it.
>
> I have removed that line from CONFIG_SITE because I don’t think it is
> what we really want to do anyway, but this definitely seems like a
> dangerous bug in EPICS 7. That directory could have had local edits
> that were lost.
The problem also occurs in the Base-7 modules and is caused by these
lines in configure/RULES_TOP:
> ifneq ($(INSTALL_LOCATION),$(TOP))
> UNINSTALL_DIRS += $(INSTALL_CONFIG)
> endif
Since INSTALL_CONFIG is in these cases pointing to a configure directory
that we didn't create, the uninstallDirs make target shouldn't be
deleting it. I suspect we should just remove the above lines, so 'make
uninstall' never deletes that particular directory.
- Andrew
--
Arguing for surveillance because you have nothing to hide is no
different than making the claim, "I don't care about freedom of
speech because I have nothing to say." -- Edward Snowdon
- Replies:
- Re: Problem with INSTALL_LOCATION and "make uninstall" in 7.0.1 Ralph Lange
- References:
- Problem with INSTALL_LOCATION and "make uninstall" in 7.0.1 Mark Rivers
- Navigate by Date:
- Prev:
Problem with INSTALL_LOCATION and "make uninstall" in 7.0.1 Mark Rivers
- Next:
Re: Problem with INSTALL_LOCATION and "make uninstall" in 7.0.1 Ralph Lange
- Index:
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
<2018>
2019
2020
2021
2022
2023
2024
- Navigate by Thread:
- Prev:
Problem with INSTALL_LOCATION and "make uninstall" in 7.0.1 Mark Rivers
- Next:
Re: Problem with INSTALL_LOCATION and "make uninstall" in 7.0.1 Ralph Lange
- Index:
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
<2018>
2019
2020
2021
2022
2023
2024
|