Experimental Physics and
Industrial Control System

Review: Needs Fixing

This will (of course) need to be applied to 3.15 and merged up, since Windows builds of pva2pva are failing to build against that release because of CALLBACK errors.

However looking at when the pva2pva build started failing I'm reasonably confident that including osiSock.h towards the top of both pdbsingle.cpp and pvif.cpp was probably the trigger. If you were to move that include below dbNotify.h I suspect that will fix the problem without needing this MR.

I still approve of this change, but against 3.15 instead of 7.0. It does need Release Notes too, there were none in the previous step and if you want people to change their code that needs to be documented. They should probably say that we won't deprecate CALLBACK in any 3.15 release.
-- 
https://code.launchpad.net/~epics-core/epics-base/+git/database/+merge/372385
Your team EPICS Core Developers is subscribed to branch epics-base:7.0.

References:

[Merge] ~epics-core/epics-base/+git/database:epicsCallback into epics-base:7.0 mdavidsaver via Core-talk

Navigate by Date:

Prev: Build failed in Jenkins: epics-pva2pva-vx68 #239 APS Jenkins via Core-talk

Next: Re: [Merge] ~epics-core/epics-base/+git/database:epicsCallback into epics-base:7.0 mdavidsaver via Core-talk

Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  <2019>  2020  2021  2022  2023  2024 

Navigate by Thread:

Prev: Re: [Merge] ~epics-core/epics-base/+git/database:epicsCallback into epics-base:7.0 Andrew Johnson via Core-talk

Next: Re: [Merge] ~epics-core/epics-base/+git/database:epicsCallback into epics-base:7.0 mdavidsaver via Core-talk

Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  <2019>  2020  2021  2022  2023  2024