Experimental Physics and
Industrial Control System
| 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 <2014> 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 | Index | 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 <2014> 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 |
| <== Date ==> | <== Thread ==> |
|---|
| Subject: | RE: Streamdevice 2.6 autoconnection failure using drvAsynSerialPort |
| From: | Mark Rivers <[email protected]> |
| To: | 'Mazanec Tomáš' <[email protected]>, "[email protected]" <[email protected]> |
| Date: | Mon, 7 Apr 2014 16:36:26 +0000 |
|
Hi Tomas, There were no substantive changes in the drvAsynSerialPort code between asyn 4.18 and asyn 4.21. SVN tag 1917 is asyn 4.18 and tag 2203 is asyn 4.21. Here are the differences: corvette:asyn/asyn/drvAsynSerial>svn diff -r1917:2203 drvAsynSerialPort* Index: drvAsynSerialPort.c =================================================================== --- drvAsynSerialPort.c (revision 1917) +++ drvAsynSerialPort.c (revision 2203) @@ -103,12 +103,12 @@ if ((ioctl(tty->fd, FIOBAUDRATE, tty->baud) < 0) && (ioctl(tty->fd, SIO_BAUD_SET, tty->baud) < 0)) { epicsSnprintf(pasynUser->errorMessage, pasynUser->errorMessageSize, - "SIO_BAUD_SET failed: %s\n", strerror(errno)); + "SIO_BAUD_SET failed: %s", strerror(errno)); return asynError; } if (ioctl(tty->fd, SIO_HW_OPTS_SET, tty->termios.c_cflag) < 0) { epicsSnprintf(pasynUser->errorMessage, pasynUser->errorMessageSize, - "SIO_HW_OPTS_SET failed: %s\n", strerror(errno)); + "SIO_HW_OPTS_SET failed: %s", strerror(errno)); return asynError; } #else @@ -116,7 +116,7 @@ tty->termios.c_cflag |= CREAD; if (tcsetattr(tty->fd, TCSANOW, &tty->termios) < 0) { epicsSnprintf(pasynUser->errorMessage, pasynUser->errorMessageSize, - "tcsetattr failed: %s\n", strerror(errno)); + "tcsetattr failed: %s", strerror(errno)); return asynError; } #endif @@ -253,12 +253,12 @@ } if(cfsetispeed(&tty->termios,baudCode) < 0 ) { epicsSnprintf(pasynUser->errorMessage,pasynUser->errorMessageSize, - "cfsetispeed returned %s\n",strerror(errno)); + "cfsetispeed returned %s",strerror(errno)); return asynError; } if(cfsetospeed(&tty->termios,baudCode) < 0 ) { epicsSnprintf(pasynUser->errorMessage,pasynUser->errorMessageSize, - "cfsetospeed returned %s\n",strerror(errno)); + "cfsetospeed returned %s",strerror(errno)); return asynError; } } @@ -452,7 +452,7 @@ tcflush(tty->fd, TCOFLUSH); #endif #ifdef vxWorks - ioctl(tty->fd, FIOCANCEL, NULL); + ioctl(tty->fd, FIOCANCEL, 0); /* * Since it is possible, though unlikely, that we got here before the * slow system call actually started, we arrange to poke the thread @@ -509,14 +509,14 @@ */ if ((tty->fd = open(tty->serialDeviceName, O_RDWR|O_NOCTTY|O_NONBLOCK, 0)) < 0) { epicsSnprintf(pasynUser->errorMessage,pasynUser->errorMessageSize, - "%s Can't open %s\n", + "%s Can't open %s", tty->serialDeviceName, strerror(errno)); return asynError; } #if defined(FD_CLOEXEC) && !defined(vxWorks) if (fcntl(tty->fd, F_SETFD, FD_CLOEXEC) < 0) { epicsSnprintf(pasynUser->errorMessage,pasynUser->errorMessageSize, - "Can't set %s close-on-exec flag: %s\n", + "Can't set %s close-on-exec flag: %s", tty->serialDeviceName, strerror(errno)); close(tty->fd); tty->fd = -1; @@ -578,7 +578,7 @@ asynPrint(pasynUser, ASYN_TRACE_FLOW, "%s write.\n", tty->serialDeviceName); asynPrintIO(pasynUser, ASYN_TRACEIO_DRIVER, data, numchars, - "%s write %d\n", tty->serialDeviceName, numchars); + "%s write %lu\n", tty->serialDeviceName, (unsigned long)numchars); if (tty->fd < 0) { epicsSnprintf(pasynUser->errorMessage,pasynUser->errorMessageSize, "%s disconnected:", tty->serialDeviceName); @@ -672,7 +672,7 @@ } if (maxchars <= 0) { epicsSnprintf(pasynUser->errorMessage,pasynUser->errorMessageSize, - "%s maxchars %d Why <=0?\n",tty->serialDeviceName,(int)maxchars); + "%s maxchars %d Why <=0?",tty->serialDeviceName,(int)maxchars); return asynError; } if (tty->readTimeout != pasynUser->timeout) { @@ -775,8 +775,8 @@ data[nRead] = 0; else if (gotEom) *gotEom = ASYN_EOM_CNT; - asynPrint(pasynUser, ASYN_TRACE_FLOW, "%s read %d, return %d\n", - tty->serialDeviceName, *nbytesTransfered, status); + asynPrint(pasynUser, ASYN_TRACE_FLOW, "%s read %lu, return %d\n", + tty->serialDeviceName, (unsigned long)*nbytesTransfered, status); return status; } So the changes are removing “\n” from the end of epicsSNprintf formats, and some other minor changes to avoid compiler warnings. Is this on Linux? Have you upgraded the OS? I think any change in behavior is likely due either to a change in StreamDevice or a change in the OS, and not due to any change in asyn. Mark From: [email protected] [mailto:[email protected]]
On Behalf Of Mazanec Tomáš
|
- Replies:
- RE: Streamdevice 2.6 autoconnection failure using drvAsynSerialPort Mazanec Tomáš
- References:
- Streamdevice 2.6 autoconnection failure using drvAsynSerialPort Mazanec Tomáš
- Navigate by Date:
- Prev: reminder for visa application of EPICS meeting 2014 Yuan He
- Next: RE: SYNC not updating VAL - motor Mooney, Tim M.
- Index: 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 <2014> 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024
- Navigate by Thread:
- Prev: Streamdevice 2.6 autoconnection failure using drvAsynSerialPort Mazanec Tomáš
- Next: RE: Streamdevice 2.6 autoconnection failure using drvAsynSerialPort Mazanec Tomáš
- Index: 1994 1995 1996 1997 1998 1999 2000 2001 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 <2014> 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024
·
Home
·
News
·
About
·
Base
·
Modules
·
Extensions
·
Distributions
·
Download
·
· Search · EPICS V4 · IRMIS · Talk · Bugs · Documents · Links · Licensing ·