devAaiCamac.c and devAaoCamac.c (RE:)

[Johnny Tang <tang@cebaf.gov>]

===========================================
This mail is made of the recycled electrons
===========================================
Mailer: Elm [revision: 70.85]


The code will be modified to:

     if (paao->ftvl == 0 || paao->ftvl>DBF_ENUM ){
         paao->bptr = (char *)calloc(paao->nelm,MAX_STRING_SIZE);
     }
     else {
          paao->bptr = (char *)calloc(paao->nelm,sizeofTypes[paao->ftvl]);
     }
     return(0);

Thanks for the comments.

Johnny Tang
CEBAF

> 
> Hi,
> 
>   in devAaiCamac.c and devAaoCamac.c files, calloc function is used to
> allocate memory space for an array by the following code.
> 
>     if (paao->ftvl == 0)
>         paao->bptr = (char *)calloc(paao->nelm,MAX_STRING_SIZE);
>     paao->bptr = (char *)calloc(paao->nelm,sizeofTypes[paao->ftvl]);
>     return(0);
> 
> In the case of paao->ftvl==0, the first allocated block is just replaced by
> new block in the following sentence. 
> I think the code ubove should read,
> 
>     if (paao->ftvl == 0){
>         paao->bptr = (char *)calloc(paao->nelm,MAX_STRING_SIZE);
>     }
>     else {
>          paao->bptr = (char *)calloc(paao->nelm,sizeofTypes[paao->ftvl]);
>     }
>     return(0);
> 
> 
> Any comments?
> Noboru Yamamoto
> KEK, KEKB accelerator control group.
> 


--
=============================================================
Johnny Tang     Voice: (804)249-7239  E-Mail: tang@cebaf.gov
Continous Electron Beam Accelerator Facility
12000 Jefferson Avernue, MS 85A
Newport News, Va 23606
=============================================================