RE: areadetector dbExpand.pl error: Braces must be closed in the same file they open in.

[Mark Rivers <rivers@cars.uchicago.edu>]

I have found and fixed the problem.

The problem was that NDPluginSupport.dbd was lacking a trailing newline on the last line.  This problem was introduced recently when the new NDPluginCircularBuffer plugin was added.

The EPICS 3.14.12.4 build system is tolerant of this problem.  The EPICS 3.15.1 build system is not.

I added the newline and now the master branch of ADCore builds fine on 3.15.  I verified that removing the newline again reproduces the problem on 3.15, but not on 3.14.

Mark


-----Original Message-----
From: Mooney, Tim M. [mailto:mooney@aps.anl.gov] 
Sent: Friday, January 09, 2015 5:25 PM
To: Mark Rivers; Johnson, Andrew N.; 'Heinz P. Junkes'; tech-talk@aps.anl.gov (tech-talk@aps.anl.gov)
Subject: RE: areadetector dbExpand.pl error: Braces must be closed in the same file they open in.

Hi Mark,

I tried with a bazaar checkout of base.  It worked as before.
(The build in my previous message was actually against 3.15.1 from the tar file, not the Dec 1,2014 bazaar checkout, as I said it was.)

Then I tried the most recent ADCore, and I get the same error you got. 

Here's my perl version:

    This is perl, v5.10.1 (*) built for x86_64-linux-thread-multi

    Copyright 1987-2009, Larry Wall

Tim Mooney (mooney@aps.anl.gov) (630)252-5417
Software Services Group (www.aps.anl.gov)
Advanced Photon Source, Argonne National Lab


________________________________________
From: Mark Rivers [rivers@cars.uchicago.edu]
Sent: Friday, January 09, 2015 2:28 PM
To: Mooney, Tim M.; Johnson, Andrew N.; 'Heinz P. Junkes'; tech-talk@aps.anl.gov (tech-talk@aps.anl.gov)
Subject: RE: areadetector dbExpand.pl error: Braces must be closed in the       same    file they open in.

Hi Tim,

Can you try running a bazaar checkout of EPICS base today, and also using the git master branch of ADCore?

I just updated busy, calc, asyn, sscan, and autosave to the latest SVN versions, and it still fails for me.

Could it be a difference in the perl version?  This is mine:

corvette:~/devel-3.15/areaDetector/ADCore>perl --version

This is perl 5, version 12, subversion 4 (v5.12.4) built for x86_64-linux-thread-multi

Copyright 1987-2010, Larry Wall


Thanks,
Mark


-----Original Message-----
From: Mooney, Tim M. [mailto:mooney@aps.anl.gov]
Sent: Friday, January 09, 2015 1:49 PM
To: Johnson, Andrew N.; Mark Rivers; 'Heinz P. Junkes'; tech-talk@aps.anl.gov (tech-talk@aps.anl.gov)
Subject: RE: areadetector dbExpand.pl error: Braces must be closed in the same file they open in.

I'm doing what I think is effectively the same build, but I don't see that error:

perl -CSD /home/oxygen/MOONEY/epics/base-3.15.1/bin/linux-x86_64/dbdExpand.pl  -I. -I.. -I../O.Common -I../../../dbd -I/home/oxygen/MOONEY/epics/base-3.15.1/dbd -I/home/oxygen/MOONEY/epics/synApps_3.15/support/areaDetector-2-0/ADCore/dbd -I/home/oxygen/MOONEY/epics/synApps_3.15/support/asyn-4-25/dbd -I/home/oxygen/MOONEY/epics/synApps_3.15/support/calc-3-4-2/dbd -I/home/oxygen/MOONEY/epics/synApps_3.15/support/sscan-2-10/dbd -I/home/oxygen/MOONEY/epics/synApps_3.15/support/busy-1-6-1/dbd -I/home/oxygen/MOONEY/epics/synApps_3.15/support/autosave-5-5/dbd -o simDetectorApp.dbd simDetectorSupport.dbd commonDriverSupport.dbd

version differences:
your build           my build
areaDetector-2-1 areadetector-2-0 (but I do have ADCore-2-1, which I think is the relevant version number)
calc-3-4-1           calc-3-4-2
busy-1-6             busy-1-6-1
autosave-5-4-2    autosave-5-5
The .dbd files are the same in these versions of calc, busy, and autosave

I'm also working against a bazaar checkout, last updated Dec 1, 2014, but I think it's 3.15.1

Tim Mooney (mooney@aps.anl.gov) (630)252-5417
Software Services Group (www.aps.anl.gov)
Advanced Photon Source, Argonne National Lab


________________________________________
From: tech-talk-bounces@aps.anl.gov [tech-talk-bounces@aps.anl.gov] on behalf of Andrew Johnson [anj@aps.anl.gov]
Sent: Friday, January 09, 2015 11:43 AM
To: Rivers, Mark L.; 'Heinz P. Junkes'; tech-talk@aps.anl.gov (tech-talk@aps.anl.gov)
Subject: Re: areadetector dbExpand.pl error: Braces must be closed in the       same    file they open in.

Hi Mark,

On 01/09/2015 10:16 AM, Mark Rivers wrote:
>
> Creating dbd file simDetectorApp.dbd
> perl -CSD /corvette/usr/local/epics/base-3.15.0/bin/linux-x86_64/dbdExpand.pl  -I. -I.. -I../O.Common -I../../../dbd -I/corvette/usr/local/epics/base-3.15.0/dbd -I/corvette/home/epics/devel-3.15/asyn-4-25/dbd -I/corvette/home/epics/devel-3.15/areaDetector-2-1/ADCore/dbd -I/corvette/home/epics/devel-3.15/calc-3-4-1/dbd -I/corvette/home/epics/devel-3.15/busy-1-6/dbd -I/corvette/home/epics/devel-3.15/sscan-2-10/dbd -I/corvette/home/epics/devel-3.15/autosave-5-4-2/dbd -o simDetectorApp.dbd simDetectorSupport.dbd commonDriverSupport.dbd
> dbdExpand.pl: Leaving context "file '/corvette/home/epics/devel-3.15/areaDetector-2-1/ADCore/dbd/commonDriverSupport.dbd'", found "file '/corvette/home/epics/devel-3.15/areaDetector-2-1/ADCore/dbd/NDPluginSupport.dbd'" instead.
>                 Braces must be closed in the same file they open in.
> Context: file '/corvette/home/epics/devel-3.15/areaDetector-2-1/ADCore/dbd/commonDriverSupport.dbd'
>   while reading 'commonDriverSupport.dbd' to create 'simDetectorApp.dbd'
> dbdExpand.pl: Exiting due to errors
> make[3]: *** [../O.Common/simDetectorApp.dbd] Error 255
>
>
> Andrew, I don't see any braces in ADCore/ADApp/commonDriverMakefile.  Can you tell me what is causing this error in 3.15, while it builds OK in 3.14.12.4?

This has nothing to do with the content of the Makefile, the error is
being reported by the dbdExpand.pl script while it's trying to create
the simDetectorApp.dbd file. I'm not sure what the problem is yet
because I don't have full build of ADCore with all the synApps modules.
It's not necessarily a mismatched brace as the error suggests, that was
just a common cause for the mismatched internal context which is being
reported.

>> Creating dbd file simDetectorApp.dbd
>> perl -CSD /home/h1/EPICS/base/bin/linux-x86_64/dbdExpand.pl  -I. -I.. -I../O.Common -I../../../dbd -I/home/h1/EPICS/base/dbd -I/home/h1/EPICS/support/asyn4-25/dbd -I/home/h1/EPICS/support/areaDetector/ADCore/dbd -I/home/h1/EPICS/support/calc-3-4/dbd -I/home/h1/EPICS/support/busy-1-6-1/dbd -I/home/h1/EPICS/support/sscan-2-10/dbd -I/home/h1/EPICS/support/autosave-5-5/dbd -o simDetectorApp.dbd simDetectorSupport.dbd commonDriverSupport.dbd
>> dbdExpand.pl: Leaving context "file '/home/h1/EPICS/support/areaDetector/ADCore/dbd/commonDriverSupport.dbd'", found "file '/home/h1/EPICS/support/areaDetector/ADCore/dbd/NDPluginSupport.dbd'" instead.
>>              Braces must be closed in the same file they open in.
>> Context: file '/home/h1/EPICS/support/areaDetector/ADCore/dbd/commonDriverSupport.dbd'
>>    while reading 'commonDriverSupport.dbd' to create 'simDetectorApp.dbd'
>> dbdExpand.pl: Exiting due to errors

The command is being asked to read in the files simDetectorSupport.dbd
and commonDriverSupport.dbd and to output the fully-expanded result into
the file simDetectorApp.dbd. It is somehow getting confused while doing
that, which is a little strange but the parser does try to keep careful
track of and check its current state.

There are dome debug variables in the Perl code which should help me
track down the problem, but I may not going to be able to get to this
until the end of next week, I'll be away on travel until Thursday.

Heinz: The quickest way for you to continue would be to switch to using
Base-3.14.12.4 (or an earlier 3.14.12 release) instead of 3.15.1, would
that be a possibility? Base-3.15.1 is still fairly new and a lot of
modules have not been built against it yet, so you should be prepared
for a few problems like this if you do need to use it.

- Andrew
--
People everywhere confuse what they read in newspapers with news.
-- A. J. Liebling