RE: base 7.0.7 build fails on RHEL7

["Pearson, Matthew via Tech-talk" <tech-talk at aps.anl.gov>]

Thanks Steve, I thought it must be somewhere, but I couldn’t find it when I searched tech-talk yesterday and I didn’t think to search core-talk.

 

I can confirm this patch works for me too:

https://launchpadlibrarian.net/659784147/genVersionHeader.patch

 

It works on RHEL7 (git 1.8.3.1), RHEL8 (git 2.31.1) and RHEL9 (git 2.31.1)

 

Cheers,

Matt

 

From: Hartman, Steven <hartmansm at ornl.gov>
Sent: Wednesday, April 5, 2023 8:38 PM
To: Pearson, Matthew <pearsonmr at ornl.gov>; tech-talk at aps.anl.gov
Subject: Re: base 7.0.7 build fails on RHEL7

 

Hi Matt

 

This was recently reported and investigated by Dirk … 

 

https://epics.anl.gov/core-talk/2023/msg00071.php

 

 

-- 

Steven Hartman

hartmansm @ornl.gov

 

---

From: Tech-talk <tech-talk-bounces at aps.anl.gov> on behalf of Pearson, Matthew via Tech-talk <tech-talk at aps.anl.gov>
Sent: Wednesday, April 5, 2023 6:35:18 PM
To: tech-talk at aps.anl.gov <tech-talk at aps.anl.gov>
Subject: [EXTERNAL] base 7.0.7 build fails on RHEL7

 

Hi,

 

I’ve come across a build issue for EPICS base 7.0.7 on RHEL7:

 

In file included from ../misc/epicsRelease.c:19:0:

../O.Common/epicsVCS.h:9:34: warning: missing terminating " character [enabled by default]

   #define EPICS_VCS_VERSION_DATE "Git: 2022-10-13 16:28:54 -0400

                                  ^

../O.Common/epicsVCS.h:10:1: warning: missing terminating " character [enabled by default]

"

^

../O.Common/epicsVCS.h:10:1: error: missing terminating " character

../misc/epicsRelease.c: In function ‘coreRelease’:

../misc/epicsRelease.c:26:5: error: missing terminating " character

     printf ( "## %s\n", "Rev. Date " EPICS_VCS_VERSION_DATE );

     ^

 

 

The same base version builds fine on RHEL8 and RHEL9. The base is cloned from a locally hosted GitLab.

 

On my RHEL7 system where the build fails the epicsVCS.h file looks like:

 

/* Generated file, do not edit! */

 

/* Version determined from Git */

 

#ifndef EPICS_VCS_VERSION

  #define EPICS_VCS_VERSION "rel7.0.7_20230322-3-gc33bc056721ad1cc8e79"

#endif

#ifndef EPICS_VCS_VERSION_DATE

  #define EPICS_VCS_VERSION_DATE "Git: 2022-10-13 16:28:54 -0400

"

#endif

 

 

The final “ on the EPICS_VCS_VERSION_DATE line is on the wrong line.

 

On my RHEL8 system it looks like:

 

/* Generated file, do not edit! */

 

/* Version determined from Git */

 

#ifndef EPICS_VCS_VERSION

  #define EPICS_VCS_VERSION "rel7.0.7_20230322-3-gc33bc056721ad1cc8e79"

#endif

#ifndef EPICS_VCS_VERSION_DATE

  #define EPICS_VCS_VERSION_DATE "Git: 2022-10-13 16:28:54 -0400"

#endif

 

 

If I download a fresh version of 7.0.7 as a tar file and build that on RHEL7, that same file becomes:

 

/* Generated file, do not edit! */

 

/* Version determined from build date/time */

 

#ifndef EPICS_VCS_VERSION

  #define EPICS_VCS_VERSION "2023-04-05T18:29-0400"

#endif

#ifndef EPICS_VCS_VERSION_DATE

  #define EPICS_VCS_VERSION_DATE "build date/time: "

#endif

 

And the build works fine.

 

I assume it’s something to do with an older Git version. Any ideas?

 

The EPICS_VCS_VERSION_DATE seems new in 7.0.7. It wasn’t in 7.0.6.1 (which built fine on RHEL7 via the Git clone from our local GitLab copy of base).

 

Cheers,

Matt