Argonne National Laboratory

Experimental Physics and
Industrial Control System

2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  <20122013  2014  2015  2016  2017  2018  2019  Index 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  <20122013  2014  2015  2016  2017  2018  2019 
<== Date ==> <== Thread ==>

Subject: Re: [Merge] lp:~ralph-lange/epics-base/thread-hooks into lp:epics-base
From: Andrew Johnson <anj@aps.anl.gov>
To: Ralph Lange <Ralph.Lange@gmx.de>
Date: Mon, 02 Jul 2012 18:45:36 -0000
Hi Ralph,

Thanks.

Sorry, a couple more issues, then I think I'm done:

The name 'epicsShowThreadInfo' implies this routine is part of the epicsShow subsystem.  The original name 'showThreadInfo' was static and thus only used internally to the posix implementation, but if you're making it visible I think it needs to match the other epicsThread... names.  Maybe name it epicsThreadShowPrivate(), which matches the Win32 implementation (although there the routine is static).

If you don't intend that routine to be called by user code the declaration for it doesn't have to appear in any header files either, it could just appear in the posix/osdThread.c file where it's used.  I would also prefer that it take an epicsThreadId argument instead of the epicsThreadOSD* pointer; that should remain for internal use only (epicsThread.h has a typedef making the two identical).

- Andrew

-- 
https://code.launchpad.net/~ralph-lange/epics-base/thread-hooks/+merge/112806
Your team EPICS Core Developers is requested to review the proposed merge of lp:~ralph-lange/epics-base/thread-hooks into lp:epics-base.


Replies:
Re: [Merge] lp:~ralph-lange/epics-base/thread-hooks into lp:epics-base Ralph Lange
References:
[Merge] lp:~ralph-lange/epics-base/thread-hooks into lp:epics-base Ralph Lange

Navigate by Date:
Prev: Re: [Merge] lp:~ralph-lange/epics-base/thread-hooks into lp:epics-base Ralph Lange
Next: Re: [Merge] lp:~ralph-lange/epics-base/thread-hooks into lp:epics-base Andrew Johnson
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  <20122013  2014  2015  2016  2017  2018  2019 
Navigate by Thread:
Prev: Re: [Merge] lp:~ralph-lange/epics-base/thread-hooks into lp:epics-base Ralph Lange
Next: Re: [Merge] lp:~ralph-lange/epics-base/thread-hooks into lp:epics-base Ralph Lange
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  <20122013  2014  2015  2016  2017  2018  2019 
ANJ, 26 Nov 2012 Valid HTML 4.01! · Home · News · About · Base · Modules · Extensions · Distributions · Download ·
· Search · EPICS V4 · IRMIS · Talk · Bugs · Documents · Links · Licensing ·