Experimental Physics and
Industrial Control System

Ralph Lange <[email protected]> · Wed, 7 Sep 2016 09:52:01 +0200

On 07/09/2016 01:31, Michael Davidsaver wrote:

On 09/06/2016 07:04 PM, Andrew Johnson wrote:

While merging the 3.15 changes into 3.16 I discovered these conflicting
changes. Which one is correct, and if it's the 3.16 change, should it be
back-ported to 3.15?

I think yours, though it may not make a difference practically.  If
copyInHeader() only fails in allocRawMsg() fails, in which case I think
no new message is ready to be sent.  In this case I would think that
commitMsg() is either a no-op, or an error.  I haven't look far enough
to tell which is the case.

+1

My fix was only to suppress the "variable set but not used" warning, and

not setting it was the easy fix without behavior change.

Cheers,
~Ralph

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System