| 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 <2020> 2021 2022 2023 2024 2025 | Index | 2002 2003 2004 2005 2006 2007 2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 <2020> 2021 2022 2023 2024 2025 |
| <== Date ==> | <== Thread ==> |
|---|
| Subject: | Re: [Merge] ~dirk.zimoch/epics-base:dbChannelForDBLinks into epics-base:7.0 |
| From: | mdavidsaver via Core-talk <core-talk at aps.anl.gov> |
| To: | mp+378968 at code.launchpad.net |
| Date: | Sat, 16 May 2020 02:08:29 -0000 |
Two points.
1. Please avoid merging 7.0 in a feature branch. git-rebase is the preferred way to update (if necessary).
2. I do my local builds with -Werror=implicit-function-declaration
which turns up a missing '#define EPICS_PRIVATE_API' in dbChannel.c
../db/dbChannel.c:70:5: error: implicit declaration of function ‘db_init_event_freelists’; did you mean ‘db_init_events’? [-Werror=implicit-function-declaration]
db_init_event_freelists();
^~~~~~~~~~~~~~~~~~~~~~~
db_init_events
Also, as a minor point. There is no reason to decorate private API like db_init_event_freelists() with epicsShareFunc unless it is called from test code.
--
https://code.launchpad.net/~dirk.zimoch/epics-base/+git/epics-base/+merge/378968
Your team EPICS Core Developers is subscribed to branch epics-base:7.0.