Re: Minor issue with base 7.0.4.1

["Johnson, Andrew N. via Core-talk" <core-talk at aps.anl.gov>]

Hi Mark,

On Aug 26, 2020, at 5:42 PM, Mark Rivers via Core-talk <core-talk at aps.anl.gov> wrote:

I just updated base to 7.0.4.1

 

When I run “make –sj clean uninstall” on Centos 7 I get the following error message:

 

corvette:local/epics-devel/base-7.0.4>make -sj clean uninstall

Can't open perl script "/usr/local/epics-devel/base-7.0.4/bin/linux-x86_64/fullPathName.pl": No such file or directory

 

I think the command worked OK, but the error message is disconcerting.

Do the changes below fix that particular problem? It will probably behave differently on my machines, so I think you will have to test it to be sure:

diff --git a/configure/RULES_TOP b/configure/RULES_TOP

index b956839ec..9cac51c68 100644

--- a/configure/RULES_TOP

+++ b/configure/RULES_TOP

@@ -33,7 +33,7 @@ UNINSTALL_DIRS += $(INSTALL_INCLUDE) $(INSTALL_TEMPLATES) $(DIRECTORY_TARGETS)

 ifneq ($(INSTALL_LOCATION),$(TOP))

   UNINSTALL_DIRS += $(INSTALL_CONFIG)

 endif

-uninstallDirs:

+uninstallDirs: | clean

        $(RMDIR) $(UNINSTALL_DIRS)

 

   # Remove the bin and lib directories if they have no sub-directories

@@ -41,12 +41,12 @@ uninstallDirs:

 EMPTY_INSTALL_DIRS = \

     $(if $(wildcard $(INSTALL_LOCATION_BIN)/*),,$(INSTALL_LOCATION_BIN)) \

     $(if $(wildcard $(INSTALL_LOCATION_LIB)/*),,$(INSTALL_LOCATION_LIB))

-uninstall: archuninstall uninstallDirs

+uninstall: archuninstall uninstallDirs | clean

        $(RMDIR) $(EMPTY_INSTALL_DIRS)

 

 archuninstall: $(addprefix uninstall$(DIVIDER),$(BUILD_ARCHS))

 

-uninstall$(DIVIDER)%:

+uninstall$(DIVIDER)%: | clean

        $(RMDIR) $(addsuffix /$(subst uninstall$(DIVIDER),,$@), \

            $(INSTALL_LOCATION_BIN) $(INSTALL_LOCATION_LIB))

 

Those are order-only-prerequisites that tell GNUmake to wait for the ‘make clean’ to finish (if you’ve asked it to do that) before deleting the top-level dir’s. However o-o-p’s don’t always do what you might expect with phony targets.

- Andrew

-- 

Complexity comes for free, simplicity you have to work for.