Experimental Physics and
Industrial Control System

mdavidsaver via Core-talk <core-talk at aps.anl.gov> · Tue, 02 Feb 2021 16:09:10 -0000

Review: Approve

... __GLIBC_PREREQ

Ah, sorry I didn't catch this.  There is a difference in how CPP treats undefined "variable" vs. "function" macros.  eg. an undefined __GNUC__ will silently expand to zero.  An undefined __GLIBC_PREREQ() is an error.

What you have is fine, and no further change is needed.  So I think this change is now ready to merge.

I will note that this could also be expressed using the VERSION_INT() macro from epicsVersion.h as

> #ifdef __GLIBC__
> #define GLIBC_VERSION VERSION_INT(__GLIBC__, __GLIBC_MINOR__, 0, 0)
> #endif

and then

> #if GLIBC_VERSION >= VERSION_INT(2,4,0,0)

This works since an undefined GLIBC_VERSION is treated as a zero.

> ... The CI environments should ...

This is currently being controlled by '.github/workflows/ci-scripts-build.yml'.  As a first pass, I should be sufficient to apply 'sudo' to the following line.

>      run: python .ci/cue.py test

-- 
https://code.launchpad.net/~dirk.zimoch/epics-base/+git/epics-base/+merge/394327
Your team EPICS Core Developers is subscribed to branch epics-base:7.0.

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System