Experimental Physics and
Industrial Control System

Michael Davidsaver via Core-talk <core-talk at aps.anl.gov> · Sat, 17 Apr 2021 11:10:34 -0700

On 4/17/21 10:46 AM, Zimoch Dirk (PSI) via Core-talk wrote:
> Hi folks,
> 
> My compiler is throwing new warnings at me:
> freeList.h:44:2: warning: no newline at end of file
> (committed 2021-03-08)

Ah, I didn't notice this.

https://github.com/epics-base/epics-base/pull/121/files#diff-9154fa56cfad3841361b708dba2417a28e7c1686f827d8268412e9d50cb1b6b2R44

> Is there a way to enforce some file format conventions before accepting source files in git?
> I would prefer to enforce:
> 1. No files without newline at the end.
> 2. No source code files with tabs in them.
> 3. Consistent indents (4?)
> 4. No whitespace at end of line.  (Ok, that's a minor thing actually)

launchpad.net doesn't allow custom git hook scripts, which would be the
obvious way to enforce this.  (neither does the github.com free service)

The next best thing would be adding a style/linter check to the CI builds.

I'm a bit hesitant to enforce too many style checks, although what you list
seems reasonable.

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System