RE: PCAS fails to build with latest epics base

[Freddie Akeroyd - STFC UKRI via Core-talk <core-talk at aps.anl.gov>]

Thanks - I've created a couple of PRs:

- caProto.h change is against 7.0 as the 3.15 version of the file does not include osdSock.h
- epicsMMIODef.h change is against 3.15, but as the 7.0 version already includes <libComAPI.h> it would be more tidying up rather than stopping any potential compile fail

Regards,

Freddie

> -----Original Message-----
> From: Michael Davidsaver <mdavidsaver at gmail.com>
> Sent: 25 June 2021 01:12
> To: Akeroyd, Freddie (STFC,RAL,ISIS) <freddie.akeroyd at stfc.ac.uk>
> Cc: EPICS core-talk (core-talk at aps.anl.gov) <core-talk at aps.anl.gov>
> Subject: Re: PCAS fails to build with latest epics base
> 
> On 6/24/21 5:05 PM, Freddie Akeroyd - STFC UKRI via Core-talk wrote:
> > Hi,
> >
> >
> >
> > I was just trying a recent EPICS base master with our build tree and had an
> issue compiling the PCAS module. PCAS includes just <caProto.h> and this file
> then includes <osdSock.h> and fails to compile as LIBCOM_API is not defined.
> There are several ways to fix this, I wasn't sure which was preferred:
> >
> >
> >
> > ·         caProto.h could include osiSock.h rather than osdSock.h
> 
> I think this is the right solution.
> 
> From a quick look, I see two other which needs fixing as well.
> 
> > $ grep -R 'include.*osd' include
> ...
> > include/os/Linux/epicsMMIODef.h:#include <osdSock.h>
> > include/os/RTEMS/epicsMMIODef.h:#include <osdSock.h>
> 
> 
> 
> 
> > ·         caProto.h could include libComAPI.h before osdSock.h
> >
> >
> >
> > Regards,
> >
> >
> >
> > Freddie
> >
> >
> >
> > This email and any attachments are intended solely for the use of the named
> recipients. If you are not the intended recipient you must not use, disclose,
> copy or distribute this email or any of its attachments and should notify the
> sender immediately and delete this email from your system. UK Research and
> Innovation (UKRI) has taken every reasonable precaution to minimise risk of
> this email or any attachments containing viruses or malware but the recipient
> should carry out its own virus and malware checks before opening the
> attachments. UKRI does not accept any liability for any losses or damages
> which the recipient may sustain due to presence of any viruses. Opinions,
> conclusions or other information in this message and attachments that are not
> related directly to UKRI business are solely those of the author and do not
> represent the views of UKRI.
> >


This email and any attachments are intended solely for the use of the named recipients. If you are not the intended recipient you must not use, disclose, copy or distribute this email or any of its attachments and should notify the sender immediately and delete this email from your system. UK Research and Innovation (UKRI) has taken every reasonable precaution to minimise risk of this email or any attachments containing viruses or malware but the recipient should carry out its own virus and malware checks before opening the attachments. UKRI does not accept any liability for any losses or damages which the recipient may sustain due to presence of any viruses. Opinions, conclusions or other information in this message and attachments that are not related directly to UKRI business are solely those of the author and do not represent the views of UKRI.