possible bug in et_wish R3.12.2

[Matthieu Bec <mdcb@ing.iac.es>]

Dear all,

I think there's bug in et_wish / R3.12.2 :

using asynchronous links, the data structures are not correctly
allocated.

After successfull connection, the handler use argument of type
DBR_STS/DBR_CTRL to retrieve initial values, and subsequently allocate
memory using these types.

The monitor/get operations work on DBR_TIME, hence it screws up.


I run a simple test monitoring strings where we allocate 44 bytes rather
than the expected 52 for DBR_TIME_STRING.



here's my suggested fix (tclCa.c):



/*******************************************************
* whenever async cntl data is received...retrieve info buffer
 *******************************************************/
void updateChCtrl(struct event_handler_args args) {

  CHANDATA *pch;
  INFOBUF *pinfo;
  int nBytes;
  int status;

  pch = (CHANDATA *)args.usr;
  nBytes = dbr_size_n(args.type,args.count);
  pinfo = &pch->info;

  memcpy((char *)pinfo, args.dbr, (size_t)nBytes);

  /*
  modified by mdcb 990421: at this stage - args is still a DBR_STS or
DBR_CTRL
  pch->initSize = nBytes;
  */
	
  /* we actually want DBR_TIME */
  pch->initSize =
dbr_size_n(dbf_type_to_DBR_TIME(pch->iType),args.count);
  
  
  /* now does calloc ... */
  updateLink(pch);
}




PS: I posted a mail few times ago to try and find out who was looking
after et_wish, is this package still supported ?

Cheers,

  Matthieu




-- 
Matthieu Bec                       Isaac Newton Group
tel  : +34 922 425427              Apartado de Correos 321
fax  : +34 922 425401              38780 Santa Cruz de La Palma
url  : www.ing.iac.es/~mdcb        Canary Islands, Spain