Experimental Physics and
Industrial Control System

Andrew Johnson <[email protected]> · Fri, 12 Sep 2008 09:43:58 -0500

On Friday 12 September 2008 07:49:54 Benjamin Franksen wrote:
> ...or at least it looks like one.
>
> Take a look at asChangeClient, defined in src/as/asLibRoutines.c. Whereas
> asAddClient (which is defined immediately before asChangeClient) converts
> the host name to lower case, asChangeClient does not. This routine is used
> by the (old) CA server in reaction to the client_name and host_name
> messages.

I agree it sure looks like it.  This patch will go into R3.14.10.

- Andrew

Index: ../as/asLibRoutines.c
===================================================================
RCS file: /net/phoebus/epicsmgr/cvsroot/epics/base/src/as/asLibRoutines.c,v
retrieving revision 1.35.2.13
diff -d -u -b -p -r1.35.2.13 asLibRoutines.c

--- ../as/asLibRoutines.c       3 May 2007 20:37:41 -0000       1.35.2.13
+++ ../as/asLibRoutines.c       12 Sep 2008 14:39:16 -0000
@@ -360,9 +360,13 @@ long epicsShareAPI asChangeClient(
 {
     ASGCLIENT  *pasgclient = asClientPvt;
     long       status;
+    int                ind;

     if(!asActive) return(S_asLib_asNotActive);
     if(!pasgclient) return(S_asLib_badClient);
+    for(ind=0; ind<strlen(host); ind++) {
+        host[ind] = (char)tolower((int)host[ind]);
+    }
     LOCK;
     pasgclient->level = asl;
     pasgclient->user = user;

-- 
Talk is cheap. Show me the code. -- Linus Torvalds


Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System