EPICS Controls Argonne National Laboratory

Experimental Physics and
Industrial Control System

1994  1995  1996  1997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  <20142015  2016  2017  2018  2019  2020  2021  2022  2023  2024  Index 1994  1995  1996  1997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  <20142015  2016  2017  2018  2019  2020  2021  2022  2023  2024 
<== Date ==> <== Thread ==>

Subject: Re: Bug in Asyn 4-23 drvAsynUSBTMC (with patch)
From: Eric Norum <[email protected]>
To: Bruno Martins <[email protected]>, Mark Rivers <[email protected]>
Cc: "[email protected]" <[email protected]>
Date: Wed, 19 Nov 2014 11:48:04 -0800
Ooops.
Thanks for catching that.
I had no ‘large transfer’ pieces of equipment and clearly I missed a line!
Change and updated ChangeLog applied to subversion repository.


> On Nov 19, 2014, at 10:53 AM, Bruno Martins <[email protected]> wrote:
> 
> Hi all,
> 
> I'm using drvAsynUSBTMC to talk to a Tektronix scope and found a bug.
> 
> asynOctetRead (in drvAsynUSBTMC.c) tries to fill the passed 'data' pointer with data from 'pdpvt->bufp'. However, if 'maxchars' > 'pdpvt->bufCount'  a new packet will be requested from the USB driver and be saved to 'pdpvt->bufp'. Then, in the next 'for' loop iteration, 'data' will be overwritten. 
> 
> The fix is to increment 'data' pointer by the appropriate amount. A patch is attached.
> 
> 
> 
> Thanks,
> 
> Bruno
> <usbtmc.patch>

-- 
Eric Norum
[email protected]






References:
Bug in Asyn 4-23 drvAsynUSBTMC (with patch) Bruno Martins

Navigate by Date:
Prev: Bug in Asyn 4-23 drvAsynUSBTMC (with patch) Bruno Martins
Next: Beckhoff EtherCAT Motion Control D'Ewart, J. Mitch
Index: 1994  1995  1996  1997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  <20142015  2016  2017  2018  2019  2020  2021  2022  2023  2024 
Navigate by Thread:
Prev: Bug in Asyn 4-23 drvAsynUSBTMC (with patch) Bruno Martins
Next: Beckhoff EtherCAT Motion Control D'Ewart, J. Mitch
Index: 1994  1995  1996  1997  1998  1999  2000  2001  2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  <20142015  2016  2017  2018  2019  2020  2021  2022  2023  2024 
ANJ, 17 Dec 2015 Valid HTML 4.01! · Home · News · About · Base · Modules · Extensions · Distributions · Download ·
· Search · EPICS V4 · IRMIS · Talk · Bugs · Documents · Links · Licensing ·