Experimental Physics and
Industrial Control System

Hinko Kocevar <[email protected]> · Tue, 26 Jun 2018 08:16:12 +0000

Hi Mark,

thank you for the fast solution! I'll give it run in the next weeks and report!

Best,
Hinko

________________________________________
From: Mark Rivers <[email protected]>
Sent: Monday, June 25, 2018 10:30:10 PM
To: Hinko Kocevar; [email protected]; [email protected]
Subject: RE: time series circular buffer

Hi Hinko,

I have implemented the change to the NDPluginStats plugin using the second method I suggested:

- Move the time series code out of the statistics plugin and have the statistics plugin send the time points as NDArrays to time series plugins.

This has the benefit of reducing the code by 240 lines while adding the functionality of the Circular Buffer mode.

The only downside is that it breaks backwards compatibility.  The names of the PVs for the time-series arrays are unchanged, but the PVs to control the time-series (start/stop, number of time points, etc.) are slightly changed.  I think this is probably OK because I doubt if these are widely used in client scripts.

I have put the new version in this branch of ADCore on Github: https://github.com/areaDetector/ADCore/tree/stats_time_series.  There is a pending pull-request for it.  If you (or anyone else) wants to test and comment that would be welcome.

Thanks,
Mark

From: Hinko Kocevar <[email protected]>
Sent: Tuesday, June 19, 2018 8:28 AM
To: [email protected]; [email protected]; Mark Rivers <[email protected]>
Subject: RE: time series circular buffer

Hi Mark,

sounds like both approaches might be acceptable. I guess it is about code duplication vs. number of different plugins one needs to get this feature, when it comes to deciding where to place this.

thanks,
hinko

--
Hinko Kocevar
Beam Diagnostics Engineer
European Spallation Source ERIC
P.O Box 176, SE-221 00 Lund, Sweden
Visiting address: Odarslövsvägen 113, 224 84 Lund
Mobile: +46-721-79 22 58
Phone:  +46-46-888 32 58
E-mail: [email protected]<mailto:[email protected]>
Web:    www.esss.se<http://www.esss.se>

On 2018-06-16 01:07:11+02:00 Mark Rivers wrote:

Hi Hinko,

I think it would be useful to be able to run the time series in circular buffer mode.  There are 2 ways this might be done:

- Add the code for circular buffer mode to the statistics plugin

- Move the time series code out of the statistics plugin and have the statistics plugin send the time points as NDArrays to time series plugins.

I'm not sure which is best.

I have created an issue for this in ADCore.

Thanks,

Mark

-----Original Message-----

From: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>> On Behalf Of Hinko Kocevar

Sent: Friday, June 15, 2018 3:55 AM

To: [email protected]<mailto:[email protected]>; Tech-talk <[email protected]<mailto:[email protected]>>

Subject: Re: time series circular buffer

Hi Tom,

thanks for the suggestion, I have not used this particular plugin so far. I'll give it a try!

Cheers,

Hinko

________________________________________

From: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>>

Sent: Friday, June 15, 2018 9:44:57 AM

To: Hinko Kocevar; Tech-talk

Subject: RE: time series circular buffer

Hi,

There is the NDPluginAttrPlot plugin which takes any numeric stamped NDAttributes (like the ones the NDPluginStats produces) and puts them in a circular buffer, periodically pushing the last N samples to a set of waveforms. We use it to plot arbitrary attributes against each other.

http://cars9.uchicago.edu/software/epics/NDPluginAttrPlot.html

Thanks,

Tom

&gt; -----Original Message-----

&gt; From: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>> On

&gt; Behalf Of Hinko Kocevar

&gt; Sent: 15 June 2018 07:38

&gt; To: Tech-talk <[email protected]<mailto:[email protected]>>

&gt; Subject: time series circular buffer

&gt;

&gt; Hi,

&gt;

&gt; in areaDetector NDPluginStats plugin I can get nice timeseries plots

&gt; for max, mean, min.

&gt; After the number of predefined points are collected the storing stops.

&gt; Is there a way to configure timeseries buffer as a circular buffer?

&gt; I've noticed that NDTimeSeries has this feature, but I'm failing to

&gt; find one in NDPluginStats.

&gt;

&gt; Thanks,

&gt;

&gt; Hinko Kocevar

&gt;

&gt; Beam Diagnostics Engineer

&gt; European Spallation Source ERIC

&gt; P.O Box 176, SE-221 00 Lund, Sweden

&gt; Visiting address: Odarslövsvägen 113, SE-224 84 Lund , Sweden

&gt;

&gt; Mobile: +46-721-79 22 58

&gt; Phone:  +46-46-888 32 58

&gt;

&gt; E-mail: [email protected]<mailto:[email protected]>

&gt; Web:    www.esss.se<http://www.esss.se>

--

This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.

Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.

Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.

Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom

</[email protected]<mailto:/[email protected]>></[email protected]<mailto:/[email protected]>></[email protected]<mailto:/[email protected]>></[email protected]<mailto:/[email protected]>></[email protected]<mailto:/[email protected]>>

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System