Experimental Physics and
Industrial Control System

Andy Foster <[email protected]> · Thu, 25 Mar 2004 18:02:58 +0000 (GMT)

Hi Dick, Ron,

I got round this by adding __STRICT_ANSI__ within
vxWorks.h like this:

(This is line number 199)
#if defined( __STRICT_ANSI__ )

/*
 * In case TOOL_FAMILY isn't defined, we shal assume gnu for
 * backward compatibility.  All this is so we can include
 * the toolMacros.h file from the h/tool/$(TOOL_FAMILY) directory
 * path.  This is needed because for host tool building we can't
 * always specify additional include paths for compiler tool
 * builds.
 */

#ifndef TOOL_FAMILY
#   define TOOL_FAMILY gnu
#endif

/* All this to generate a string we can #include */

#define TOOL_HDR_STRINGIFY(x)  #x
#define TOOL_HDR(tc, file) TOOL_HDR_STRINGIFY(tool/tc/file)
#define TOOL_HEADER(file) TOOL_HDR(TOOL_FAMILY,file)

/* Now include the correct header file */

#include TOOL_HEADER(toolMacros.h)
#endif  /* __STRICT_ANSI__ */

Cheers,

Andy

On Thu, 25 Mar 2004, Dirk Zimoch wrote:

> Ronald L. Sluiter wrote:
> > I am beginning to wonder if there is any combination of compiler
> > switches that will allow one to build R3.13.9 using Tornado 2.2.1
>
> Yes. Tornado2.2 vxWorks.h is not compatible with the -traditional flag.
>
> > I don't understand it, but here is what is happening to drvBitBus.c.
> >
> > The following is a segment from vxWorks.h;
> >
> >    /* All this to generate a string we can #include */
> >
> >    #define TOOL_HDR_STRINGIFY(x)  #x
> >    #define TOOL_HDR(tc, file) TOOL_HDR_STRINGIFY(tool/tc/file)
> >    #define TOOL_HEADER(file) TOOL_HDR(TOOL_FAMILY,file)
> >
> >    /* Now include the correct header file */
> >
> >    #include TOOL_HEADER(toolMacros.h)
> >
> > The above "#include TOOL_HEADER(toolMacros.h)" is processed into
> > the following in drvBitBus.c;
> >
> >    #tool/gnu/toolMacros.h
> >
> > It is like the "include" part of "#include" got lost.  This yields the
> > error message;
> >
> > ..../wind68K2.2/target/h/vxWorks.h:218: `#include' expects "FILENAME" or
> > <FILENAME>
> >
> > Ron
> >
>
> I think, with the -traditional flag, the preprocessor does not know the
> '#x' stringify feature. Thus, the line expands to:
>
> #include #GNU/tc/toolMacros.h
>
> Now, the preprocessor gets lost.
>
> I've removed the -traditional flag everywhere and found, that the
> problems with src/drv/old are (mainly?) because of sloppy/lazy/buggy
> programming:
>
> There are just not enough arguments provided to logMsg() and
> taskSpawn(). Solution: fill with 0's.
>
> I've not tried it because the bug occurs quite often in several files,
> but it should help.
>
> Dirk
>
> --
> Dr. Dirk Zimoch
> Swiss Light Source
> Paul Scherrer Institut
> Computing and Controls
> phone +41 56 310 5182
> fax   +41 56 310 4413
>

--------------------------------------------------------------------
Observatory Sciences Limited    Email: [email protected]
William James House             Tel: 44 - (0)1223 - 508259
Cowley Road                     Fax: 44 - (0)1223 - 508258
Cambridge, CB4 0WX, UK          http://www.observatorysciences.co.uk

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System