mbboDirect record

[Rolf Keitel <rolf@triumf.ca>]

I was just looking at the init_record function for the mbboDirect 
record  (Release 3.13.10) and saw the following code:

   status=(*pdset->init_record)(pmbboDirect);

       /* init_record might set status */

   if(status==0){

       rval = pmbboDirect->rval;

       if(pmbboDirect->shft>0) rval >>= pmbboDirect->shft;

       pmbboDirect->val =  (unsigned short)rval;

       pmbboDirect->udf = FALSE;

   } else if (status == 2) status = 0;

   }

   return(status);


*Shouldn't it be something like:*



   status=(*pdset->init_record)(pmbboDirect);

       /* init_record might set status */

   if(status==0){

       rval = pmbboDirect->rval;

       if(pmbboDirect->shft>0) rval >>= pmbboDirect->shft;

       /* >>>>>>>>>> */

       if (pmbboDirect->mask>0) rval &= pmbboDirect->mask

       /* <<<<<<<<<< */

       pmbboDirect->val =  (unsigned short)rval;

       pmbboDirect->udf = FALSE;

   } else if (status == 2) status = 0;

   }

   return(status);




--
+-------------------------------------------------+
| Rolf Keitel, TRIUMF Tel: (604) 222-7453 |
| Group Leader ISAC Controls Fax: (604) 222-7307 |
| and Electronics Development |
| Vancouver, B.C., Canada |
+-------------------------------------------------+