Experimental Physics and
Industrial Control System

Benjamin Franksen <[email protected]> · Tue, 10 May 2011 02:43:01 +0200

Hi Mark

Am Montag, 9. Mai 2011, um 18:32:04 schrieben Sie:
> seq-2.0.13 does not build for me on win32-x86.

Sorry for that. Note that I am *not* able to test nor build on all supported
platforms. Which is why I sent out two release candidates and waited more than
a week for people to report problems like that *before* making the release.

> The problem is the line
>
> #include <unistd.h>
>
> in src/snc/snc_lex.l.
>
> Changing this to
>
> #include <osiUnistd.h>
>
> fixes the problem.
>
> Unfortunately it appears that a number of fixes that were applied to the
> APS Subversion repository after the release of seq-2-0-12 were lost in the
> upgrade to seq-2-0-13.  This includes the fix above.

I became aware of the subversion repository at APS only after I had already
made extensive changes based on the released 2.0.12. This is why I had to
(manually) merge the changes in the APS repo after 2.0.12 into my development
branch. I tried to merge *those* changes back into 2.0.13 but I must have
overlooked this one. Note that I never expected to continue development of the
old 2.0.12 branch and that releasing 2.0.13 is purely a stop-gap measure
because the work on 2.1.0 took a lot more time than I originally expected.

> These are the logs of the commits that were made to that repository after
> the release of seq-2-0-12, which was svn tag 194.
>
> corvette:~/devel/seq-2-0-12>../utils/logModuleFromTag_asd.py sncseq
> seq-2-0-12
> ------------------------------------------------------------------------
> r195 | anj | 2009-08-16 23:41:56 -0500 (Sun, 16 Aug 2009) | 2 lines
> Changed paths:
>    M /trunk/src/seq/seq_qry.c
>
> Fix build warning on 64-bit archs.

This relates to printf warnings and is fixed in 2.0.13 since I can compile on
64 bit linux w/o getting such warnings.

> ------------------------------------------------------------------------
> r196 | anj | 2009-09-02 14:11:36 -0500 (Wed, 02 Sep 2009) | 2 lines
> Changed paths:
>    M /trunk/src/snc/phase2.c
>
> Add #include "epicsExport.h" to generated output file.

This change is in 2.0.13.

> ------------------------------------------------------------------------
> r197 | anj | 2009-09-02 14:12:38 -0500 (Wed, 02 Sep 2009) | 2 lines
> Changed paths:
>    M /trunk/src/seq/seq.h
>    M /trunk/src/seq/seqCom.h
>
> Fix SEQ_UGLY_WINDOWS_HACK properly.

This change is in 2.0.13.

> ------------------------------------------------------------------------
> r198 | anj | 2009-09-02 14:21:42 -0500 (Wed, 02 Sep 2009) | 2 lines
> Changed paths:
>    M /trunk/src/dev
>    M /trunk/src/pv
>    M /trunk/src/seq
>    M /trunk/src/snc
>
> Set svn:ignore to ignore O.* directories.

This change is irrelevant as I don't use svn.

> ------------------------------------------------------------------------
> r199 | anj | 2009-09-02 14:53:10 -0500 (Wed, 02 Sep 2009) | 2 lines
> Changed paths:
>    M /trunk/configure
>    M /trunk/test/demo
>    M /trunk/test/simple
>    M /trunk/test/validate
>
> Set svn:ignore to ignore O.* directories.

Same.

> ------------------------------------------------------------------------
> r200 | norume | 2009-09-03 12:29:46 -0500 (Thu, 03 Sep 2009) | 5 lines
> Changed paths:
>    M /trunk/src/snc/gen_ss_code.c
>    M /trunk/src/snc/gen_tables.c
>    M /trunk/src/snc/parse.c
>    M /trunk/src/snc/phase2.c
>    M /trunk/src/snc/proto.h
>    M /trunk/src/snc/snc.y
>    M /trunk/src/snc/snc_lex.l
>    M /trunk/src/snc/snc_main.c
>
> 1) Converted all functions to ANSI-style argument lists.  Fixed some call
> errors uncovered by this. 2) Added prototypes.
> 3) Fixed some pointer/int warnings.
> 4) Converted format to 'EPICS standard' (no hard tabs)

I was already done ansificating everything in the compiler when I became aware
of this change, so I ignored it. This is the only change amnong teh ones you
listed that touches src/snc/snc_lex.l, and indeed addition of the #include
<osiUnistd.h> line has been hiding here. I'll fix this, but it means I have to
make a 2.0.14 release.

> ------------------------------------------------------------------------
> r201 | rivers | 2010-10-17 22:32:46 -0500 (Sun, 17 Oct 2010) | 1 line
> Changed paths:
>    M /trunk/src/snc/Makefile
>
> Remove the fl and l libraries, they are not needed
> ------------------------------------------------------------------------

This is also fixed in 2.0.13.

Cheers
Ben

________________________________

Helmholtz-Zentrum Berlin für Materialien und Energie GmbH

Mitglied der Hermann von Helmholtz-Gemeinschaft Deutscher Forschungszentren e.V.

Aufsichtsrat: Vorsitzender Prof. Dr. Dr. h.c. mult. Joachim Treusch, stv. Vorsitzende Dr. Beatrix Vierkorn-Rudolph
Geschäftsführer: Prof. Dr. Anke Rita Kaysser-Pyzalla, Prof. Dr. Dr. h.c. Wolfgang Eberhardt, Dr. Ulrich Breuer

Sitz Berlin, AG Charlottenburg, 89 HRB 5583

Postadresse:
Hahn-Meitner-Platz 1
D-14109 Berlin

http://www.helmholtz-berlin.de

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System