Experimental Physics and
Industrial Control System

<[email protected]> · Tue, 16 Feb 2016 11:26:04 +0000

Hi Han,

In order to contact the developers (at least for areaDetector - but probably also for other modules) it is useful to simply create an issue-ticket on the github repository. For areaDetector this is often where contributors start by presenting a new idea or change that they would like to see and a discussion is had about how to best implement the new feature. If you start the description by volunteering to work on it then maintainers are usually happy to guide you in the right direction :-) 

See for example a recent ticket on areaDetector/ADCore where we had an extensive debate about a requested change: https://github.com/areaDetector/ADCore/issues/145 . I expect it is likely to be followed up with a Pull Request later on - at which point we will review and discuss the implementation details.

Cheers,
Ulrik

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Jeong Han Lee
Sent: 15 February 2016 22:31
To: Mark Rivers; [email protected]
Cc: Jeong Han Lee
Subject: Re: Guide needed in order to work with the EPICS related Git repositories

Hi Mark,

   Thank you for your workflow. It is the exactly what I am looking for!

   And I should follow your comment in order to work with EPICS projects. Actually, I did them in one EPICS project without telling anyone what I would like to do, then I thought, I forgot to discuss this early with main developers and maintainers after I saw Ralph's comment.

   Thank you again, I will understand your workflow first, then, I should do it them again with the proper procedure.

   Thanks,
   Han

On 02/15/2016 10:27 PM, Mark Rivers wrote:
> Hi Han,
>
> I'm not sure exactly what you would like.  For the EPICS areaDetector
> project there is a Github workflow guide here:
>
> https://github.com/areaDetector/areaDetector/wiki/areaDetector-Git-Workflows
>
>  It is probably always a good idea to talk to the main developers
> early.  If you are doing a small patch then cloning and doing a pull
> request back to the master branch is a typical workflow.  But if you
> are doing some major change then the developer will probably want to
> create a branch for you and other developers to work on, and then you
> do pull requests back to that branch.
>
> Mark
>
>
> -----Original Message----- From: [email protected]
> [mailto:[email protected]] On Behalf Of Jeong Han Lee
> Sent: Monday, February 15, 2016 2:47 PM To: [email protected]
> Subject: Guide needed in order to work with the EPICS related Git
> repositories
>
> Hi,
>
> I would like to have a *nice* guide, which is always I could get in
> here, in order to work with the EPICS related Git repositories at
> github.com.
>
> Is there any procedure which I should follow in order to do any pull
> requests? Should it be better to talk plan to main developers or
> maintainers before forking, doing pull requests, or both?
>
> It looks like to add more features in some existent projects in near
> future, but I don't have clear idea how to do this. Please guide me
> to minimize any difficulties.
>
> Thanks, Han
>

-- 
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd. 
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System