Re: modbus write 2 16 bits holding registers with modbus function 16

[Claudio Lambert <clambert@adc.net.ar>]

Mark,

Thanks for your help, I have been locked in this problem for a long time. I have read the documentation of newer versions without realizing that these functionalities were not available.

Claudio.

2017-06-23 12:32 GMT-03:00 Mark Rivers <rivers@cars.uchicago.edu>:

Hi Claudio,

> I'm using modbusR2-1.

OK, that explains the problem.  That is a very old (2010) version, and you are trying to use features that are not available in that release.

This is the relevant code from writeInt32:

 

            switch(pPlc->modbusFunction) {

                case MODBUS_WRITE_SINGLE_COIL:

                case MODBUS_WRITE_SINGLE_REGISTER:

                    status = doModbusIO(pPlc, pPlc->modbusSlave, pPlc->modbusFunction,

                                         modbusAddress, &data, 1);

                    if (status != asynSuccess) return(status);

                    break;

                default:

                    asynPrint(pPlc->pasynUserTrace, ASYN_TRACE_ERROR,

                              "%s::writeInt32 port %s invalid request for Modbus"

                              " function %d\n",

                              driver, pPlc->portName, pPlc->modbusFunction);

                    return(asynError);

            }

 

Note that writeInt32 does not support MODBUS_WRITE_MULTIPLE_REGISTERS in that release.

 

You are also asking for data type 6=INT32_BE.  But support for that data type was only added in R2-4, as documented in the release notes.

 

I suggest you update to the latest version, R2-9.

 

Mark

 

 

From: Claudio Lambert [mailto:clambert@adc.net.ar]
Sent: Friday, June 23, 2017 10:19 AM
To: Mark Rivers
Cc: tech-talk@aps.anl.gov
Subject: Re: modbus write 2 16 bits holding registers with modbus function 16

 

Hi Mark,

I'm using modbusR2-1.

The OS where EPICS run is GNU/Linux x86_64 and the compiler is gcc 4.4.3.

I made the correction in the noAutoConnect flag but the error persist.

As additional information, there is no error writing a single record (Function Code=6).

Thanks again,

Claudio.

 

2017-06-23 11:47 GMT-03:00 Mark Rivers <rivers@cars.uchicago.edu>:

Hi Claudio,

 

I don't understand that error message.  What version of the EPICS Modbus package are you using?

 

In the latest version that error comes from this code starting at line 964 in drvModbusAsyn.c

 

            switch(pPlc->modbusFunction) {

                case MODBUS_WRITE_SINGLE_COIL:

                    buffer[0] = value;

                    status = doModbusIO(pPlc, pPlc->modbusSlave, pPlc->modbusFunction,

                                        modbusAddress, buffer, 1);

                    if (status != asynSuccess) return(status);

                    break;

                case MODBUS_WRITE_SINGLE_REGISTER:

                    status = writePlcInt(pPlc, dataType, offset, value, buffer, &bufferLen);

                    if (status != asynSuccess) return(status);

                    for (i=0; i<bufferLen; i++) {

                        status = doModbusIO(pPlc, pPlc->modbusSlave, pPlc->modbusFunction,

                                            modbusAddress+i, buffer+i, bufferLen);

                    }

                    if (status != asynSuccess) return(status);

                    break;

                case MODBUS_WRITE_MULTIPLE_REGISTERS:

                case MODBUS_WRITE_MULTIPLE_REGISTERS_F23:

                    status = writePlcInt(pPlc, dataType, offset, value, buffer, &bufferLen);

                    if (status != asynSuccess) return(status);

                    status = doModbusIO(pPlc, pPlc->modbusSlave, pPlc->modbusFunction,

                                        modbusAddress, buffer, bufferLen);

                    if (status != asynSuccess) return(status);

                    break;

                default:

                    asynPrint(pPlc->pasynUserTrace, ASYN_TRACE_ERROR,

                              "%s::writeInt32 port %s invalid request for Modbus"

                              " function %d\n",

                              driver, pPlc->portName, pPlc->modbusFunction);

                    return asynError;

            }

 

So the error comes when it falls through the switch into the default: block.  However, it is reporting that pPlc->modbusFunction is 16, which is what MODBUS_WRITE_MULTIPLE_REGISTERS is defined to be in modbus.h.

 

#define MODBUS_WRITE_MULTIPLE_REGISTERS      0x10

 

So it should have executed the case block above the default: section, not the default section.

 

What OS and compiler are you using?

 

Also, I notice something about this command in your startup script:

 

drvAsynIPPortConfigure("NOC02","192.168.1.1:502",0,1,1)

You have set the noAutoConnect flag.  This is generally not a good idea, I would suggest changing this line to:

drvAsynIPPortConfigure("NOC02","192.168.1.1:502",0,0,1)

However, I don't think this is related to the problem you are having.

 

Mark

 

 

From: tech-talk-bounces@aps.anl.gov [mailto:tech-talk-bounces@aps.anl.gov] On Behalf Of Claudio Lambert
Sent: Friday, June 23, 2017 9:05 AM
To: tech-talk@aps.anl.gov
Subject: modbus write 2 16 bits holding registers with modbus function 16

 

Hi all, I'm trying to write 2 x 16 bits holding registers (N, N+1) at same time, but I'm obtaining the following error:

epics> dbpf NOC02:CMD_TEST 45
DBR_DOUBLE:         45                 
epics> 2017/06/23 10:40:51.678 drvModbusAsyn::writeInt32 port NOC_F16 invalid request for Modbus function 16
2017/06/23 10:40:51.678 NOC02:CMD_TEST devAsynInt32 process error

This is the configuratión for the connection and record:

drvAsynIPPortConfigure("NOC02","192.168.1.1:502",0,1,1)
modbusInterposeConfig("NOC02",0,5000)
drvModbusAsynConfigure("NOC_F16", "NOC02", 1, 16, 2, 2, 6, 2000, "TTA")


record(longout,"NOC02:CMD_TEST") {
    field(DTYP,"asynInt32")
    field(OUT,"@asyn(NOC_F16 0)")
}

Any help would be appreciated.

Thanks in advance!