Thanks, Mark,
I will roll a fix into the next release.
________________________________
From: Davis, Mark <[email protected]>
Sent: 29 May 2019 19:04:39
To: [email protected]; Knap, Giles (DLSLtd,RAL,LSCI)
Subject: pmac driver bug
To Giles and other interested parties,
I found another bug in the pmac driver (version 2-4-10):
The section of code in the pmacAxis::home() function that is
conditionally compiled based on the macro REMOVE_LIMITS_ON_HOME does not
check for the PMAC_CID_POWER CID value, so when using a Power Brick
controller it simply logs an error (if enabled) and exits.
The older version of the driver I was using had the definition of the
PMAC_CID_POWER macro commented out, so the offending section of code was
not included and it would just send the home command regardless of what
type of controller you have.
For now, I commented this macro out in the newer version to get the same
behavior as the older one.
----------------
Mark Davis
NSCL/FRIB
Control Systems Software Engineer
[email protected]
--
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
- Replies:
- Re: pmac driver bug Davis, Mark via Tech-talk
- References:
- pmac driver bug Davis, Mark via Tech-talk
- Navigate by Date:
- Prev:
RE: devSup driver development differences between base 3.14 and 3.15 Abdalla Ahmad via Tech-talk
- Next:
RE: devSup driver development differences between base 3.14 and 3.15 Abdalla Ahmad via Tech-talk
- Index:
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
<2019>
2020
2021
2022
2023
2024
- Navigate by Thread:
- Prev:
pmac driver bug Davis, Mark via Tech-talk
- Next:
Re: pmac driver bug Davis, Mark via Tech-talk
- Index:
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
<2019>
2020
2021
2022
2023
2024
|