One correction: The macro that was commented out in the older version
is REMOVE_LIMITS_ON_HOME, NOT PMAC_CID_POWER (which is a const).
Mark
Mark Davis NSCL/FRIB Control Systems Software Engineer [email protected]
On 5/30/2019 3:47 AM, [email protected] wrote:
> Thanks, Mark,
>
>
> I will roll a fix into the next release.
>
> ________________________________
> From: Davis, Mark <[email protected]>
> Sent: 29 May 2019 19:04:39
> To: [email protected]; Knap, Giles (DLSLtd,RAL,LSCI)
> Subject: pmac driver bug
>
> To Giles and other interested parties,
>
> I found another bug in the pmac driver (version 2-4-10):
>
> The section of code in the pmacAxis::home() function that is
> conditionally compiled based on the macro REMOVE_LIMITS_ON_HOME does not
> check for the PMAC_CID_POWER CID value, so when using a Power Brick
> controller it simply logs an error (if enabled) and exits.
>
> The older version of the driver I was using had the definition of the
> PMAC_CID_POWER macro commented out, so the offending section of code was
> not included and it would just send the home command regardless of what
> type of controller you have.
>
> For now, I commented this macro out in the newer version to get the same
> behavior as the older one.
>
> ----------------
> Mark Davis
> NSCL/FRIB
> Control Systems Software Engineer
> [email protected]
>
>
- Replies:
- Re: pmac driver bug giles.knap--- via Tech-talk
- References:
- pmac driver bug Davis, Mark via Tech-talk
- Re: pmac driver bug giles.knap--- via Tech-talk
- Navigate by Date:
- Prev:
Re: devSup driver development differences between base 3.14 and 3.15 Mark Rivers via Tech-talk
- Next:
Re: [EXTERNAL] Camonitor with client dictated update rate Klemen Vodopivec via Tech-talk
- Index:
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
<2019>
2020
2021
2022
2023
2024
- Navigate by Thread:
- Prev:
Re: pmac driver bug giles.knap--- via Tech-talk
- Next:
Re: pmac driver bug giles.knap--- via Tech-talk
- Index:
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
<2019>
2020
2021
2022
2023
2024
|