Experimental Physics and
Industrial Control System

"Zimoch Dirk \(PSI\) via Tech-talk" <tech-talk at aps.anl.gov> · Fri, 25 Nov 2022 09:12:06 +0000

Hello Rémi,

Please understand that my „product“ is the content of the git repository, not the tarball! The tarball is a convenience tool provided by github and by the git archive command. How that is created is not under my control. For example the next git version might change how the % formats are rendered and there is noting I can do about it.
I had added this when I got reports that people who downloaded the tarball instead of cloning the repo got errors when building the version string. And adding the version string manually has proven to be unreliable. (Means: I always forgot update it.)
I will try your proposal of %(describe:abbrev=12,tags). I did not know about %(…). If it works for me, I will use it in the next release. As I do not plan to add more tags to older versions, this should be safe. I will keep this potential problem in mind.

Dirk

> Am 25.11.2022 um 09:33 schrieb NICOLE Remi <remi.nicole at cea.fr>:
> 
> Hello! Rémi here,
> 
>> Of course I never download the tarball from git, so I did not notice.
>> The content of the .VERSION file is generated on the git server at
>> each download (by .gitattributes).
> 
> Thanks for the pointer, it makes sense now.
> 
> I think I recall that several build systems download GitHub archive as
> a faster way of downloading a specific version of a GitHub repository
> (same with GitLab).
> 
> The issue I'm having is that the %D substitution may change depending
> on what happens at a later date in the repository. Our build system
> enforces reproducible builds, so I have to check the hash to make sure
> nothing in the build chain changed. It also makes sure that the
> repository or the internet connection wasn't compromised.
> 
> Would you accept removing the REFS line? I would have liked to propose
> something like %(describe:abbrev=12,tags) but I think even then it's
> not guaranteed to be reproducible, as you can always add tags in
> earlier commits.
> 
> If you'd prefer not removing it, I think we can work around it by
> cloning the repo at a specific revision instead of fetching the zip
> archive. But I think it might bite other people in the future.
> 
> Thanks a lot!
> -- 
> Rémi NICOLE <remi.nicole at cea.fr>
> CEA/DRF/IRFU/DIS/LDISC

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System