Experimental Physics and Industrial Control System
|
Hi Freddie,
On 5/15/19 5:28 AM, Freddie Akeroyd - UKRI STFC via Core-talk wrote:
I was recently compiling EPICS base 3.15 for an earlier windows version from Windows 10 and had a compile error with the WIN32 base implementation of SetThreadName.cpp. The file always sets _WIN32_WINNT to 0x400 (Specifying Windows
NT 4.0, the comment says it is dropping support for W95!) which then conflicted with my setting of NTDDI_VERSION. The _WIN32_WINNT macro is also set to 0x400 in osdMutex.c and osdThread.c but in these files it is only set if not otherwise defined externally.
A similar check for an existing definition in SetThreadName.cpp would avoid my compile issue, but as Windows 95 and NT 4.0 are long in the past I wonder if removing these redefinitions of _WIN32_WINNT from base would now be appropriate
If you think we can safely remove all those tests and definitions from libCom/osi/os/WIN32 for the "recent-enough" versions of Windows we should support I'd be fine with doing that.
I just tried it on windows-x64 and windows-x64-mingw builds and MSVC gave me a deprecation warning for the
GetVersionEx() call in epicsMutexOsdCreate() — could we remove the
thisIsNT variable and CreateMutex() stuff from osdMutex.c as well while we're cleaning this up? It looks like the required
CRITICAL_SECTION support is present back as far as Windows XP and Windows Server 2003, which is fine as far as I'm concerned.
Thanks,
- Andrew
--
Complexity comes for free, Simplicity you have to work for.
|
- Replies:
- RE: _WIN32_WINNT defines in EPICS base Freddie Akeroyd - UKRI STFC via Core-talk
- References:
- _WIN32_WINNT defines in EPICS base Freddie Akeroyd - UKRI STFC via Core-talk
- Navigate by Date:
- Prev:
Re: Excessive scan times for periodic scans Konrad, Martin via Core-talk
- Next:
Build failed in Jenkins: 3.15-pva2pva-win64s #205 APS Jenkins via Core-talk
- Index:
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
<2019>
2020
2021
2022
2023
2024
- Navigate by Thread:
- Prev:
_WIN32_WINNT defines in EPICS base Freddie Akeroyd - UKRI STFC via Core-talk
- Next:
RE: _WIN32_WINNT defines in EPICS base Freddie Akeroyd - UKRI STFC via Core-talk
- Index:
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
<2019>
2020
2021
2022
2023
2024
|
ANJ, 17 May 2019 |
·
Home
·
News
·
About
·
Base
·
Modules
·
Extensions
·
Distributions
·
Download
·
·
Search
·
EPICS V4
·
IRMIS
·
Talk
·
Bugs
·
Documents
·
Links
·
Licensing
·
|