Experimental Physics and
Industrial Control System

mdavidsaver via Core-talk <[email protected]> · Mon, 20 May 2019 22:10:29 -0000

Wow, I didn't receive emails for any of these comments, including Ben's.  I see them in the core-talk archive though.  Not in my Spam.  And I have since received mail through the list for other MRs.  Go figure...

Anyway.

> A bit of explanation why the name 'struct Scope' may be useful

This is per-thread.  So concurrent calls from different threads will see different scopes.  However, nested calls within the same thread will see the same scope.

> It looks like "on error break" exits the current script with an error, would that then trigger the "on error" mechanism in the calling script?

The error state is only cleared before a function call.  So an error remains active though nested returns until another function is called.

It occurs to me that "on error ..." in a nested call would effect the outer frames as well, which seems potentially confusing.

> Split the calling of ioc shell registered functions out into its own function.

@Keenan, This occurred to me as well.  The API isn't trivial though.  Do you care about handling the struct iocshCmdDef* yourself?  Are you doing argument type casting?

Maybe something like:

> int iocshCmdX(const char *argtypes, size_t nargs, const iocshArgBuf *args);

Where 'types' would be a string containing 'i', 'd', 's', 'D', '*', or 'S' for each argument value.  strlen(types)==nargs would be enforced, and the first argument must be a string (the command name).

-- 
https://code.launchpad.net/~epics-core/epics-base/+git/Com/+merge/366876
Your team EPICS Core Developers is subscribed to branch epics-base:7.0.

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System