Experimental Physics and
Industrial Control System

Review: Needs Fixing

Ok, I think we are getting side tracked.  I will renamed epicsThreadJoin() -> epicsThreadMustJoin().  However, I leave epicsThreadTryJoin() as future work from someone who wants to do it, and can find a portable way.  I don't want this to hold up merging.

wrt. epicsThreadMustJoin() returning an error.  The one case I can see which could be indicated in a race free way is self join.  This is also a case which a caller can easily check and handle beforehand.  So I don't see this as sufficient motivation.

wrt. clearing joinable.  I'll change this so that trying to self join twice will be defined.  However, other cases of double join, or join of unjoinable, will remain undefined (aka. race to crash).

wrt. vxWorks and taskWait().  I can't find any documentation for this.  How does it handled a self wait?  For that matter, how does it handle waiting for a thread which might already have returned?  Does vxWorks have a notion of (not) detached threads?

wrt. Testing.  I'll extend epicsThreadTest with at least an explicit test of self join.
-- 
https://code.launchpad.net/~epics-core/epics-base/+git/Com/+merge/361379
Your team EPICS Core Developers is subscribed to branch epics-base:7.0.

Navigate by Date:

Prev: Re: IOC Threads blocking all signals William Norum via Core-talk

Next: Re: IOC Threads blocking all signals Johnson, Andrew N. via Core-talk

Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  <2019>  2020  2021  2022  2023  2024 

Navigate by Thread:

Prev: Re: [Merge] ~epics-core/epics-base/+git/Com:thread-join into epics-base:7.0 Andrew Johnson via Core-talk

Next: Re: [Merge] ~epics-core/epics-base/+git/Com:thread-join into epics-base:7.0 Andrew Johnson via Core-talk

Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  <2019>  2020  2021  2022  2023  2024