EPICS Home

Experimental Physics and Industrial Control System


 
2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  <2019>  2020  2021  2022  2023  2024  Index 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  <2019>  2020  2021  2022  2023  2024 
<== Date ==> <== Thread ==>
Subject: Re: pvPutLog?
From: "Johnson, Andrew N. via Core-talk" <[email protected]>
To: Michael Davidsaver <[email protected]>
Cc: "[email protected]" <[email protected]>
Date: Fri, 6 Sep 2019 12:39:04 +0000 
Hi Michael,

> On Sep 4, 2019, at 4:45 AM, Michael Davidsaver <[email protected]> wrote:
> 
> https://github.com/epics-modules/caPutLog/blob/b544f92c6efe1df98506b567f3f7e5137965e2a4/caPutLogApp/caPutLogAs.c#L104
> 
> dbGetField() is used, which of course calls dbScanLock().
> This is done twice, for the "before" and "after" values.
> So 'pmessage->data' is not used.
> 
> I guess I can just pass data=NULL or a dummy value.

Please look at commit c5ded30684 in Base. The asTrapWrite.h API was enhanced about 4 years ago in 3.15 and caPutLog is no longer the only external user of it. Tim Mooney's caPutRecorder module *does* rely on pmessage->data. Direct access to the data was added on his request, so he can record exactly what value was put even if the record processing subsequently modifies that field value (puts to the Motor record can fall into that category).

Someone could modify caPutLog to make use of the data field instead of calling dbGetField() twice.

- Andrew
References:
pvPutLog? Timo Korhonen via Core-talk
Re: pvPutLog? Zimoch Dirk (PSI) via Core-talk
Re: pvPutLog? Michael Davidsaver via Core-talk
Re: pvPutLog? Zimoch Dirk (PSI) via Core-talk
Re: pvPutLog? Michael Davidsaver via Core-talk
Re: pvPutLog? Timo Korhonen via Core-talk
Re: pvPutLog? Michael Davidsaver via Core-talk
Re: pvPutLog? Zimoch Dirk (PSI) via Core-talk
Re: pvPutLog? Zimoch Dirk (PSI) via Core-talk
Re: pvPutLog? Johnson, Andrew N. via Core-talk
Re: pvPutLog? Michael Davidsaver via Core-talk
Re: pvPutLog? Zimoch Dirk (PSI) via Core-talk
Re: pvPutLog? Michael Davidsaver via Core-talk
Navigate by Date:
Prev: Build failed in Jenkins: epics-example-vx69 #418 APS Jenkins via Core-talk
Next: Build failed in Jenkins: epics-example-vx68 #419 APS Jenkins via Core-talk
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  <2019>  2020  2021  2022  2023  2024 
Navigate by Thread:
Prev: Re: pvPutLog? Zimoch Dirk (PSI) via Core-talk
Next: [Bug 1842086] [NEW] TestHarness should be TESTPROD instead of PROD Dirk Zimoch via Core-talk
Index: 2002  2003  2004  2005  2006  2007  2008  2009  2010  2011  2012  2013  2014  2015  2016  2017  2018  <2019>  2020  2021  2022  2023  2024