Subject: |
Re: [Merge] ~freddie-akeroyd/epics-base:nan_inf_tests into epics-base:7.0 |
From: |
Andrew Johnson via Core-talk <[email protected]> |
To: |
[email protected] |
Date: |
Fri, 04 Oct 2019 15:19:14 -0000 |
Review: Needs Fixing
Group 10/4:
Suggest epicsCalcTest() should compare the string expression against the known expected result (for inf/nan calculations) so don't use Freddie's change as currently written to this file.
The epicsMathTest() changes are tricking the optimizer, which is a brittle thing. Idea is to concentrate these kinds of tests in this file, to document the known issues. As a result removing the compiler checks and calls to testToDo() from here is less helpful, we'd still like to see those until we stop building on compilers that fail. Having ToDo tests pass isn't a problem.
AI on MAD to merge and fix this.
--
https://code.launchpad.net/~freddie-akeroyd/epics-base/+git/epics-base/+merge/373425
Your team EPICS Core Developers is subscribed to branch epics-base:7.0.
- References:
- [Merge] ~freddie-akeroyd/epics-base:nan_inf_tests into epics-base:7.0 Freddie Akeroyd via Core-talk
- Navigate by Date:
- Prev:
Re: [Merge] ~freddie-akeroyd/epics-base:appveyor_debug_builds into epics-base:7.0 Andrew Johnson via Core-talk
- Next:
Re: [Merge] ~epics-core/epics-base/+git/Com:errlog2syslog into epics-base:7.0 Andrew Johnson via Core-talk
- Index:
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
<2019>
2020
2021
2022
2023
2024
- Navigate by Thread:
- Prev:
[Merge] ~freddie-akeroyd/epics-base:nan_inf_tests into epics-base:7.0 Freddie Akeroyd via Core-talk
- Next:
Build failed: epics-base base-7.0-328 AppVeyor via Core-talk
- Index:
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
<2019>
2020
2021
2022
2023
2024
|