Experimental Physics and
Industrial Control System

"Konrad, Martin via Core-talk" <core-talk at aps.anl.gov> · Wed, 12 Feb 2020 09:28:51 +0000

Hi Karl,
I haven't looked into the details of your findings, yet.

> 1)      Is this time well spent?
I'm seeing quite a few compiler warnings when I compile EPICS Base with
GCC 9.2. I wish we could bring this number down to zero as this makes
new issues quite hard to spot. I guess the issues reported by my GCC are
a subset of the issues reported by Codacy. Anything we can do to make
these issues more visible to the guys using older tool-chains is useful.
Fixing the issues that already exist is certainly helpful as well.

BTW: I would also consider sloppy tests a problem. For example return
codes should be evaluated in tests as well. In many cases a simple
"assert" should be sufficient to make the tools happy and to make the
tests more robust at the same time.

-Martin

-- 
Martin Konrad
Facility for Rare Isotope Beams
Michigan State University
640 South Shaw Lane
East Lansing, MI 48824-1321, USA
Tel. 517-908-7253
Email: konrad at frib.msu.edu

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System