Re: Results from analyzing Codacy issues

["Konrad, Martin via Core-talk" <core-talk at aps.anl.gov>]

>> - Possible null pointer dereferencing. In a handful of instances
>> pointers are dereferenced without NULL check. The pointer should
>> not be NULL, so practical impact is probably low. But correcting is
>> again very easy.
> 
> If the routine is static (so only visible to other routines inside
> the same source file) I would prefer to not add unnecessary NULL
> tests, but for routines that are meant to be a public API NULL tests
> probably should be added. IMHO, others may have a different opinion…
On the other hand compilers might optimize unneeded null checks away if
they can tell that a variable cannot be null. A modern compiler and
link-time optimization might be required to make this happen, though.

-Martin

-- 
Martin Konrad
Facility for Rare Isotope Beams
Michigan State University
640 South Shaw Lane
East Lansing, MI 48824-1321, USA
Tel. 517-908-7253
Email: konrad at frib.msu.edu