Experimental Physics and
Industrial Control System

Ben Franksen via Core-talk <core-talk at aps.anl.gov> · Thu, 26 Mar 2020 18:31:11 -0000

Am 26.03.20 um 17:56 schrieb Dirk Zimoch via Core-talk:
> I have re-structured the code a bit to make it less confusing. Also
> debug output is in. Tell me if you like it, then I will push it
> (without the debug code).

Yes, this is a lot better. I especially like the comments you added.

However, before you push it: have you looked at the commit from my
branch that I mentioned that moves the scalar request optimization from
the link layer to dbChannel? You could cherry-pick that using

git fetch lp:~bfrk/epics-base write-filters-rebased:bfrk-write-filters
git cherry-pick df1a6da43a5af37f72436a335f727064072ca3d8

(and hopefully don't get conflicts)

Your numbers have convinced me that this optimization is indeed worth
the trouble, so I thought it makes sense to generalize it so that every
call to dbChannelGet can profit from it (e.g. CA links).

Since otherwise dbChannelGet is completely trivial, this has the
positive side-effect of disentangling the optimization from the code
that runs the filters; which in turn addresses my complaint about the
logic being a bit hard to follow here.

This is a slightly more far-reaching change but I think it is
alltogether the better approach to clean this up.

(I also extended the optimization to work even if there are filters,
although what you wrote in your other comment suggests that this won't
have much impact.)

________________________________

Helmholtz-Zentrum Berlin für Materialien und Energie GmbH

Mitglied der Hermann von Helmholtz-Gemeinschaft Deutscher Forschungszentren e.V.

Aufsichtsrat: Vorsitzender Dr. Volkmar Dietz, stv. Vorsitzende Dr. Jutta Koch-Unterseher
Geschäftsführung: Prof. Dr. Bernd Rech (Sprecher), Prof. Dr. Jan Lüning, Thomas Frederking

Sitz Berlin, AG Charlottenburg, 89 HRB 5583

Postadresse:
Hahn-Meitner-Platz 1
D-14109 Berlin

-- 
https://code.launchpad.net/~dirk.zimoch/epics-base/+git/epics-base/+merge/378968
Your team EPICS Core Developers is subscribed to branch epics-base:7.0.

Experimental Physics and Industrial Control System

Experimental Physics and
Industrial Control System